make Configuration#Get methods virtual

half-ogre · nulltoken · commit f5fe1eef3d49 · 2013-01-26T23:32:39.000+01:00
The commit libgit2@3d29d95 moved #Get overloads to extension methods. The problem is the remaining #Get methods aren't virtual, which means you can't stub in unit tests. Which broke a bunch of GHfW tests.
diff --git a/LibGit2Sharp/Configuration.cs b/LibGit2Sharp/Configuration.cs
@@ -180,7 +180,7 @@ protected virtual void Dispose(bool disposing)
         /// <typeparam name = "T">The configuration value type</typeparam>
         /// <param name = "key">The key</param>
         /// <returns>The <see cref="ConfigurationEntry{T}"/>, or null if not set</returns>
-        public ConfigurationEntry<T> Get<T>(string key)
+        public virtual ConfigurationEntry<T> Get<T>(string key)
         {
             Ensure.ArgumentNotNullOrEmptyString(key, "key");
 
@@ -208,7 +208,7 @@ public ConfigurationEntry<T> Get<T>(string key)
         /// <param name = "key">The key</param>
         /// <param name = "level">The configuration file into which the key should be searched for</param>
         /// <returns>The <see cref="ConfigurationEntry{T}"/>, or null if not set</returns>
-        public ConfigurationEntry<T> Get<T>(string key, ConfigurationLevel level)
+        public virtual ConfigurationEntry<T> Get<T>(string key, ConfigurationLevel level)
         {
             Ensure.ArgumentNotNullOrEmptyString(key, "key");
 
