Move BuildSignatureFromGlobalConfiguration() to Configuration

Saaman · Saaman · commit 4d92ed4e054e · 2013-04-25T10:30:58.000+02:00
diff --git a/LibGit2Sharp/Configuration.cs b/LibGit2Sharp/Configuration.cs
@@ -287,5 +287,18 @@ private IEnumerable<ConfigurationEntry<string>> BuildConfigEntries()
                                                       (ConfigurationLevel)entry.level);
             });
         }
+
+        internal Signature BuildSignatureFromGlobalConfiguration(DateTimeOffset now)
+        {
+            var name = Get<string>("user.name");
+            var email = Get<string>("user.email");
+
+            if ((name == null) || (email == null))
+            {
+                throw new LibGit2SharpException("Can not find Name and Email settings of the current user in Git configuration.");
+            }
+
+            return new Signature(name.Value, email.Value, now);
+        }
     }
 }
diff --git a/LibGit2Sharp/RepositoryExtensions.cs b/LibGit2Sharp/RepositoryExtensions.cs
@@ -173,7 +173,7 @@ private static Commit LookUpCommit(IRepository repository, string committish)
         /// <returns>The generated <see cref = "LibGit2Sharp.Commit" />.</returns>
         public static Commit Commit(this IRepository repository, string message, bool amendPreviousCommit = false)
         {
-            Signature author = BuildSignatureFromGlobalConfiguration(repository, DateTimeOffset.Now);
+            Signature author = repository.Config.BuildSignatureFromGlobalConfiguration(DateTimeOffset.Now);
 
             return repository.Commit(message, author, amendPreviousCommit);
         }
@@ -191,7 +191,7 @@ public static Commit Commit(this IRepository repository, string message, bool am
         /// <returns>The generated <see cref = "LibGit2Sharp.Commit" />.</returns>
         public static Commit Commit(this IRepository repository, string message, Signature author, bool amendPreviousCommit = false)
         {
-            Signature committer = BuildSignatureFromGlobalConfiguration(repository, DateTimeOffset.Now);
+            Signature committer = repository.Config.BuildSignatureFromGlobalConfiguration(DateTimeOffset.Now);
 
             return repository.Commit(message, author, committer, amendPreviousCommit);
         }
@@ -224,19 +224,6 @@ public static void Fetch(this IRepository repository, string remoteName,
                 onTransferProgress, credentials);
         }
 
-        private static Signature BuildSignatureFromGlobalConfiguration(IRepository repository, DateTimeOffset now)
-        {
-            var name = repository.Config.Get<string>("user.name");
-            var email = repository.Config.Get<string>("user.email");
-
-            if ((name == null) || (email == null))
-            {
-                throw new LibGit2SharpException("Can not find Name and Email settings of the current user in Git configuration.");
-            }
-
-            return new Signature(name.Value, email.Value, now);
-        }
-
         /// <summary>
         ///   Checkout the specified <see cref = "Branch" />, reference or SHA.
         /// </summary>

Original file line number	Diff line number	Diff line change
`@@ -287,5 +287,18 @@ private IEnumerable<ConfigurationEntry<string>> BuildConfigEntries()`
`287`	`287`	`(ConfigurationLevel)entry.level);`
`288`	`288`	`});`
`289`	`289`	`}`
	`290`	`+`
	`291`	`+ internal Signature BuildSignatureFromGlobalConfiguration(DateTimeOffset now)`
	`292`	`+ {`
	`293`	`+ var name = Get<string>("user.name");`
	`294`	`+ var email = Get<string>("user.email");`
	`295`	`+`
	`296`	`+ if ((name == null) \|\| (email == null))`
	`297`	`+ {`
	`298`	`+ throw new LibGit2SharpException("Can not find Name and Email settings of the current user in Git configuration.");`
	`299`	`+ }`
	`300`	`+`
	`301`	`+ return new Signature(name.Value, email.Value, now);`
	`302`	`+ }`
`290`	`303`	`}`
`291`	`304`	`}`