Skip to content

Commit 7376201

Browse files
committed
Fix failure due to included files when using vscode's log level enum
1 parent e4ff8e1 commit 7376201

2 files changed

Lines changed: 10 additions & 22 deletions

File tree

packages/logger/src/logger.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22
* Log level.
33
*/
44
export enum Level {
5-
Debug = 0,
6-
Info = 1,
7-
Warn = 2,
8-
Error = 3,
5+
Trace,
6+
Debug,
7+
Info,
8+
Warning,
9+
Error,
910
}
1011

1112
/**
@@ -229,7 +230,7 @@ export class Logger {
229230
switch (envLevel) {
230231
case "debug": this.level = Level.Debug; break;
231232
case "info": this.level = Level.Info; break;
232-
case "warn": this.level = Level.Warn; break;
233+
case "warn": this.level = Level.Warning; break;
233234
case "error": this.level = Level.Error; break;
234235
}
235236
}
@@ -272,7 +273,7 @@ export class Logger {
272273
message,
273274
fields,
274275
tagColor: "#FF9D00",
275-
level: Level.Warn,
276+
level: Level.Warning,
276277
});
277278
}
278279

packages/server/src/vscode/sharedProcess.ts

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import * as path from "path";
55
import { forkModule } from "./bootstrapFork";
66
import { StdioIpcHandler } from "../ipc";
77
import { ParsedArgs } from "vs/platform/environment/common/environment";
8-
import { LogLevel } from "vs/platform/log/common/log";
98
import { Emitter } from "@coder/events/src";
109
import { retry } from "@coder/ide/src/retry";
10+
import { logger, Level } from "@coder/logger";
1111

1212
export enum SharedProcessState {
1313
Stopped,
@@ -80,30 +80,17 @@ export class SharedProcess {
8080
});
8181
this.ipcHandler = new StdioIpcHandler(this.activeProcess);
8282
this.ipcHandler.once("handshake:hello", () => {
83-
let logLevel = LogLevel.Warning;
84-
const envLevel = typeof global !== "undefined" && typeof global.process !== "undefined" ? global.process.env.LOG_LEVEL : process.env.LOG_LEVEL;
85-
if (envLevel) {
86-
switch (envLevel) {
87-
case "trace": logLevel = LogLevel.Trace; break;
88-
case "debug": logLevel = LogLevel.Debug; break;
89-
case "info": logLevel = LogLevel.Info; break;
90-
case "warn": logLevel = LogLevel.Warning; break;
91-
case "error": logLevel = LogLevel.Error; break;
92-
case "critical": logLevel = LogLevel.Critical; break;
93-
case "off": logLevel = LogLevel.Off; break;
94-
}
95-
}
9683
const data: {
9784
sharedIPCHandle: string;
9885
args: Partial<ParsedArgs>;
99-
logLevel: LogLevel;
86+
logLevel: Level;
10087
} = {
10188
args: {
10289
"builtin-extensions-dir": this.builtInExtensionsDir,
10390
"user-data-dir": this.userDataDir,
10491
"extensions-dir": extensionsDir,
10592
},
106-
logLevel,
93+
logLevel: logger.level,
10794
sharedIPCHandle: this.socketPath,
10895
};
10996
this.ipcHandler!.send("handshake:hey there", "", data);

0 commit comments

Comments
 (0)