Default.Cast: reformat and docs

Nucs · Nucs · commit f208c4a4cfbd · 2019-08-07T17:00:00.000+03:00
diff --git a/src/NumSharp.Core/Backends/Default/ArrayManipulation/Default.Cast.cs b/src/NumSharp.Core/Backends/Default/ArrayManipulation/Default.Cast.cs
@@ -12,8 +12,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)
             if (dtype == NPTypeCode.Empty)
                 throw new ArgumentNullException(nameof(dtype));
 
-            NDArray clone() => new NDArray(nd.Storage.Clone());
-
+            //incase its an empty array
             if (nd.Shape.IsEmpty)
             {
                 if (copy)
@@ -23,6 +22,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)
                 return nd;
             }
 
+            //incase its a scalar
             if (nd.Shape.IsScalar)
             {
                 var ret = NDArray.Scalar(nd.GetAtIndex(0), dtype);
@@ -33,6 +33,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)
                 return nd;
             }
 
+            //incase its a (1,) shaped
             if (nd.Shape.size == 1 && nd.Shape.NDim == 1)
             {
                 var ret = new NDArray(ArraySlice.Scalar(nd.GetAtIndex(0), dtype), Shape.Vector(1));
@@ -43,6 +44,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)
                 return nd;
             }
 
+            //regular clone
             if (nd.GetTypeCode == dtype)
             {
                 //casting not needed
@@ -65,6 +67,8 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)
                     return nd;
                 }
             }
+
+            NDArray clone() => nd.Clone();
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)`
`12`	`12`	`if (dtype == NPTypeCode.Empty)`
`13`	`13`	`throw new ArgumentNullException(nameof(dtype));`
`14`	`14`
`15`		`- NDArray clone() => new NDArray(nd.Storage.Clone());`
`16`		`-`
	`15`	`+ //incase its an empty array`
`17`	`16`	`if (nd.Shape.IsEmpty)`
`18`	`17`	`{`
`19`	`18`	`if (copy)`
`@@ -23,6 +22,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)`
`23`	`22`	`return nd;`
`24`	`23`	`}`
`25`	`24`
	`25`	`+ //incase its a scalar`
`26`	`26`	`if (nd.Shape.IsScalar)`
`27`	`27`	`{`
`28`	`28`	`var ret = NDArray.Scalar(nd.GetAtIndex(0), dtype);`
`@@ -33,6 +33,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)`
`33`	`33`	`return nd;`
`34`	`34`	`}`
`35`	`35`
	`36`	`+ //incase its a (1,) shaped`
`36`	`37`	`if (nd.Shape.size == 1 && nd.Shape.NDim == 1)`
`37`	`38`	`{`
`38`	`39`	`var ret = new NDArray(ArraySlice.Scalar(nd.GetAtIndex(0), dtype), Shape.Vector(1));`
`@@ -43,6 +44,7 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)`
`43`	`44`	`return nd;`
`44`	`45`	`}`
`45`	`46`
	`47`	`+ //regular clone`
`46`	`48`	`if (nd.GetTypeCode == dtype)`
`47`	`49`	`{`
`48`	`50`	`//casting not needed`
`@@ -65,6 +67,8 @@ public override NDArray Cast(NDArray nd, NPTypeCode dtype, bool copy)`
`65`	`67`	`return nd;`
`66`	`68`	`}`
`67`	`69`	`}`
	`70`	`+`
	`71`	`+ NDArray clone() => nd.Clone();`
`68`	`72`	`}`
`69`	`73`	`}`
`70`	`74`	`}`