build: setup test targets for integration tests with new rule (angular#44238)

devversion · alxhub · commit 64fd824f6765 · 2021-12-08T13:42:41.000-05:00
Sets up the test targets for integration tests with the new rule. The targets will match the configuration of the previous integration test setup (through the dictionary in a `bzl` file). Note: We already add `setup_chromium` based on whether Chromium tests run as part of this integration test. In a follow-up commit we can then remove puppeteer and rely on the Bazel-managed version of Chromium. PR Close angular#44238
diff --git a/integration/cli-elements-universal/BUILD.bazel b/integration/cli-elements-universal/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/cli-hello-world-ivy-compat/BUILD.bazel b/integration/cli-hello-world-ivy-compat/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/cli-hello-world-ivy-i18n/BUILD.bazel b/integration/cli-hello-world-ivy-i18n/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/cli-hello-world-ivy-minimal/BUILD.bazel b/integration/cli-hello-world-ivy-minimal/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/cli-hello-world-lazy/BUILD.bazel b/integration/cli-hello-world-lazy/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/cli-hello-world/BUILD.bazel b/integration/cli-hello-world/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/dynamic-compiler/BUILD.bazel b/integration/dynamic-compiler/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/forms/BUILD.bazel b/integration/forms/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/hello_world__closure/BUILD.bazel b/integration/hello_world__closure/BUILD.bazel
@@ -0,0 +1,11 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    # TODO: Re-enable the payload_size_tracking command:
+    # We should define ngDevMode to false in Closure, but --define only works in the global scope.
+    # With ngDevMode not being set to false, this size tracking test provides little value but a lot of
+    # headache to continue updating the size.
+    # commands = "payload_size_tracking",
+    setup_chromium = True,
+)
diff --git a/integration/i18n/BUILD.bazel b/integration/i18n/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/injectable-def/BUILD.bazel b/integration/injectable-def/BUILD.bazel
@@ -0,0 +1,9 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    # This test relies on ESM for running the app in SSR. RxJS added ESM resolution
+    # support with RXJS v7. We allow the version to be pinned to v7.
+    # TODO: Remove this and update the test once the project uses RxJS v7, or if rxjs v6 has ESM support.
+    pinned_npm_packages = ["rxjs"],
+)
diff --git a/integration/ivy-i18n/BUILD.bazel b/integration/ivy-i18n/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/ng-add-localize/BUILD.bazel b/integration/ng-add-localize/BUILD.bazel
@@ -0,0 +1,5 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+)
diff --git a/integration/ng_elements/BUILD.bazel b/integration/ng_elements/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/ng_update/BUILD.bazel b/integration/ng_update/BUILD.bazel
@@ -0,0 +1,5 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+)
diff --git a/integration/ng_update_migrations/BUILD.bazel b/integration/ng_update_migrations/BUILD.bazel
@@ -0,0 +1,5 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+)
diff --git a/integration/ngcc/BUILD.bazel b/integration/ngcc/BUILD.bazel
@@ -0,0 +1,15 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    use_view_engine_packages = [
+        "@angular/animations",
+        "@angular/common",
+        "@angular/core",
+        "@angular/forms",
+        "@angular/platform-browser",
+        "@angular/platform-browser-dynamic",
+        "@angular/platform-server",
+        "@angular/router",
+    ],
+)
diff --git a/integration/platform-server/BUILD.bazel b/integration/platform-server/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/service-worker-schema/BUILD.bazel b/integration/service-worker-schema/BUILD.bazel
@@ -0,0 +1,5 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+)
diff --git a/integration/side-effects/BUILD.bazel b/integration/side-effects/BUILD.bazel
@@ -0,0 +1,10 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    # The `side-effects` test is currently disabled as it does not run the
+    # Angular linker plugin and therefore partial declarations are retained
+    # as side-effects. To make this test helpful again, we need to run the linker.
+    # TODO(devversion): replace this with a solution we maintain that runs the Babel linker plugin.
+    tags = ["manual"],
+)
diff --git a/integration/terser/BUILD.bazel b/integration/terser/BUILD.bazel
@@ -0,0 +1,5 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+)
diff --git a/integration/trusted-types/BUILD.bazel b/integration/trusted-types/BUILD.bazel
@@ -0,0 +1,6 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    setup_chromium = True,
+)
diff --git a/integration/typings_test_rxjs7/BUILD.bazel b/integration/typings_test_rxjs7/BUILD.bazel
@@ -0,0 +1,7 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    # The project root uses an older version than the one we want to test here.
+    pinned_npm_packages = ["rxjs"],
+)
diff --git a/integration/typings_test_ts44/BUILD.bazel b/integration/typings_test_ts44/BUILD.bazel
@@ -0,0 +1,9 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    # Special case for `typings_test_ts44` test as we want to pin
+    # `typescript` at version 4.4.x for that test and not link to the
+    # root @npm//typescript package.
+    pinned_npm_packages = ["typescript"],
+)
diff --git a/integration/typings_test_ts45/BUILD.bazel b/integration/typings_test_ts45/BUILD.bazel
@@ -0,0 +1,9 @@
+load("//integration:index.bzl", "ng_integration_test")
+
+ng_integration_test(
+    name = "test",
+    # Special case for `typings_test_ts45` test as we want to pin
+    # `typescript` at version 4.5.x for that test and not link to the
+    # root @npm//typescript package.
+    pinned_npm_packages = ["typescript"],
+)
