Skip to content

TYP: Add .pyi type stubs for the _iterparser C-extension#20006

Draft
ReemHamraz wants to merge 1 commit into
astropy:mainfrom
ReemHamraz:iterparser-type-stubs
Draft

TYP: Add .pyi type stubs for the _iterparser C-extension#20006
ReemHamraz wants to merge 1 commit into
astropy:mainfrom
ReemHamraz:iterparser-type-stubs

Conversation

@ReemHamraz

Copy link
Copy Markdown
Contributor

Just following up on the _iterparser tests that got merged recently.

Since the C-extension yields a 4-tuple, and this PR just drops in the _iterparser.pyi stub file so the static checkers know what's going on.

Let me know if i need to tweak anything!

@github-actions github-actions Bot added the utils label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@ReemHamraz

Copy link
Copy Markdown
Contributor Author

@neutrinoceros Please lemme know your thoughts.

@pllim pllim added this to the v8.1.0 milestone Jul 1, 2026
@pllim pllim added typing related to type annotations no-changelog-entry-needed labels Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants