Recognize SyntaxError: as an error code for ecosystem checks (#16879)

ntBre · web-flow · commit 67602512b6cc · 2025-03-20T17:25:40.000-04:00
Summary -- This updates the regex in `ruff-ecosystem` to catch syntax errors in an effort to prevent bugs like #16874. This should catch `ParseError`s, `UnsupportedSyntaxError`s, and the upcoming `SemanticSyntaxError`s. Test Plan -- I ran the ecosystem check locally comparing v0.11.0 and v0.11.1 and saw a large number (2757!) of new syntax errors. I also manually tested the regex on a few lines before that. If we merge this before #16878, I'd expect to see that number decrease substantially in that PR too, as another test.
diff --git a/python/ruff-ecosystem/ruff_ecosystem/check.py b/python/ruff-ecosystem/ruff_ecosystem/check.py
@@ -45,7 +45,7 @@
 )
 
 CHECK_DIAGNOSTIC_LINE_RE = re.compile(
-    r"^(?P<diff>[+-])? ?(?P<location>.*): (?P<code>[A-Z]{1,4}[0-9]{3,4})(?P<fixable> \[\*\])? (?P<message>.*)"
+    r"^(?P<diff>[+-])? ?(?P<location>.*): (?P<code>[A-Z]{1,4}[0-9]{3,4}|SyntaxError:)(?P<fixable> \[\*\])? (?P<message>.*)"
 )
 
 CHECK_VIOLATION_FIX_INDICATOR = " [*]"

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@`
`45`	`45`	`)`
`46`	`46`
`47`	`47`	`CHECK_DIAGNOSTIC_LINE_RE = re.compile(`
`48`		`- r"^(?P<diff>[+-])? ?(?P<location>.): (?P<code>[A-Z]{1,4}[0-9]{3,4})(?P<fixable> \[\\])? (?P<message>.*)"`
	`48`	`+ r"^(?P<diff>[+-])? ?(?P<location>.): (?P<code>[A-Z]{1,4}[0-9]{3,4}\|SyntaxError:)(?P<fixable> \[\\])? (?P<message>.*)"`
`49`	`49`	`)`
`50`	`50`
`51`	`51`	`CHECK_VIOLATION_FIX_INDICATOR = " [*]"`