[red-knot] Minor: fix Literal[True] <: int (#14177)

sharkdp · web-flow · commit 2624249219af · 2024-11-07T23:23:35.000+01:00
## Summary Minor fix to `Type::is_subtype_of` to make sure that Boolean literals are subtypes of `int`, to match runtime semantics. Found this while doing some property-testing experiments [1]. [1] #14178 ## Test Plan New unit test.
diff --git a/crates/red_knot_python_semantic/src/types.rs b/crates/red_knot_python_semantic/src/types.rs
@@ -503,7 +503,7 @@ impl<'db> Type<'db> {
                 false
             }
             (Type::BooleanLiteral(_), Type::Instance(InstanceType { class }))
-                if class.is_known(db, KnownClass::Bool) =>
+                if matches!(class.known(db), Some(KnownClass::Bool | KnownClass::Int)) =>
             {
                 true
             }
@@ -2789,6 +2789,7 @@ mod tests {
     #[test_case(Ty::IntLiteral(1), Ty::BuiltinInstance("int"))]
     #[test_case(Ty::IntLiteral(1), Ty::BuiltinInstance("object"))]
     #[test_case(Ty::BooleanLiteral(true), Ty::BuiltinInstance("bool"))]
+    #[test_case(Ty::BooleanLiteral(true), Ty::BuiltinInstance("int"))]
     #[test_case(Ty::BooleanLiteral(true), Ty::BuiltinInstance("object"))]
     #[test_case(Ty::StringLiteral("foo"), Ty::BuiltinInstance("str"))]
     #[test_case(Ty::StringLiteral("foo"), Ty::BuiltinInstance("object"))]

Original file line number	Diff line number	Diff line change
`@@ -503,7 +503,7 @@ impl<'db> Type<'db> {`
`503`	`503`	`false`
`504`	`504`	`}`
`505`	`505`	`(Type::BooleanLiteral(_), Type::Instance(InstanceType { class }))`
`506`		`- if class.is_known(db, KnownClass::Bool) =>`
	`506`	`+ if matches!(class.known(db), Some(KnownClass::Bool \| KnownClass::Int)) =>`
`507`	`507`	`{`
`508`	`508`	`true`
`509`	`509`	`}`
`@@ -2789,6 +2789,7 @@ mod tests {`
`2789`	`2789`	`#[test_case(Ty::IntLiteral(1), Ty::BuiltinInstance("int"))]`
`2790`	`2790`	`#[test_case(Ty::IntLiteral(1), Ty::BuiltinInstance("object"))]`
`2791`	`2791`	`#[test_case(Ty::BooleanLiteral(true), Ty::BuiltinInstance("bool"))]`
	`2792`	`+ #[test_case(Ty::BooleanLiteral(true), Ty::BuiltinInstance("int"))]`
`2792`	`2793`	`#[test_case(Ty::BooleanLiteral(true), Ty::BuiltinInstance("object"))]`
`2793`	`2794`	`#[test_case(Ty::StringLiteral("foo"), Ty::BuiltinInstance("str"))]`
`2794`	`2795`	`#[test_case(Ty::StringLiteral("foo"), Ty::BuiltinInstance("object"))]`