Htsim integration#342
Conversation
|
Hi, |
|
Hi @AdamLatos thank you for your suggestion and my apologies on getting here so late.
|
|
Hi @AdamLatos, are you still interested in, and do you have cycles available to follow up with this PR? If yes, I can create a fork of HTSim under the astra-sim github and you could apply the changes to that fork (and make any adjustments following updates in the HTSim repo). If you do not have the bandwidth, we can do the job while acknowledging your initiative (Although I would prefer you do get the credit) |
|
Actually I just went ahead and created the fork: https://github.com/astra-sim/astra-network-uet-htsim |
|
Hi @jinsun-yoo Thank you for the review. As Adam is no longer with Marvell, I have taken ownership of this work and will be driving it forward. I've already begun addressing the feedback. I agree that Adam’s contributions should be recognized; I will retain his authorship on the patches and ensure he is properly credited as we move toward completion. |
|
Hi @SriramVatala thank you for the notification! I'll be looking forward to your patch. |
|
@jinsun-yoo Could you please review this PR? Note: This initial PR focuses strictly on the migration. I will submit a follow-up PR shortly to address the feedback left in #342 and to update the submodule pointers to the internal uet-htsim fork. |
|
@jinsun-yoo Opening as draft due to submodule dependency on astra-sim/astra-network-uet-htsim#1. Code is ready for review though. PR#364 |
Summary
As the UET htsim version was recently made public, it can now be used instead of the old version.
This pull request switches the backend to use
uet-htsiminstead ofcsg-htsim, and adds UET protocol support.In the original htsim integration, it was patched to add the necessary callback points. To align it with other network backends, the changes are now made directly in a fork of the
uet-htsimrepository. Currently the submodule points to a fork on my profile, but if a fork is opened under astra-sim github, the changes can be contributed there, if that is preferred.Original htsim PR: #309
Related issue: #203