Merge pull request #55 from stephenprater/efficient_logging

Anton Astashov · Anton Astashov · commit 8ad4eef73c76 · 2011-08-14T09:12:26.000-07:00
efficient logging
diff --git a/bin/ruby_debugger.rb b/bin/ruby_debugger.rb
@@ -168,7 +168,8 @@ def have_unclosed_tag?(output)
     def log(string)
       if @params[:debug_mode] == '1'
         File.open(@params[:logger_file], 'a') do |f|
-          f.puts 'Ruby_debugger.rb, ' + Time.now.strftime("%H:%M:%S") + ': ' + string
+          # match vim redir style new lines, rather than trailing
+          f << "\nRuby_debugger.rb, #{Time.now.strftime("%H:%M:%S")} : #{string.chomp}"
         end
       end
     end
diff --git a/src/ruby_debugger/logger.vim b/src/ruby_debugger/logger.vim
@@ -11,19 +11,20 @@ endfunction
 
 
 " Log datetime and then message. It logs only if debug mode is enabled
-" TODO: Now to add one line to the log file, it read whole file to memory, add
-" one line and write all that stuff back to file. When log file is large, it
-" affects performance very much. Need to find way to write only to the end of
-" file (preferably - crossplatform way. Maybe Ruby?)
-function! s:Logger.put(string)
+" TODO It outputs a bunch of spaces at the front of the entry - fix that.
+function! s:Logger.put(string) dict
   if g:ruby_debugger_debug_mode
-    let file = readfile(self.file)
     let string = 'Vim plugin, ' . strftime("%H:%M:%S") . ': ' . a:string
-    call add(file, string)
-    call writefile(file, self.file)
+    exec 'redir >> ' . g:RubyDebugger.logger.file
+    silent call s:Logger.silent_echo(s:strip(string))
+    exec 'redir END'
   endif
 endfunction
 
-" *** Logger class (end)
-
+function! s:Logger.silent_echo(string)
+  echo a:string
+endfunction
 
+" *** Logger class (end)
+"
+"
