Unicode→str kwargs hack only needed for Python <2.7.

JNRowe · JNRowe · commit d9ba6658a4f6 · 2011-12-13T20:08:56.000Z
diff --git a/github2/core.py b/github2/core.py
@@ -9,6 +9,9 @@
 #: Running under Python 3
 PY3K = sys.version_info[0] == 3 and True or False
 
+#: Running under Python 2.7, or newer
+PY27 = sys.version_info[:2] == 3 and True or False
+
 GITHUB_DATE_FORMAT = "%Y/%m/%d %H:%M:%S %z"
 # We need to manually mangle the timezone for commit date formatting because it
 # uses -xx:xx format
@@ -158,9 +161,9 @@ def get_value(self, *args, **kwargs):
         datatype = kwargs.pop("datatype", None)
         value = self.make_request(*args, **kwargs)
         if datatype:
-            if not PY3K:
-                # unicode keys are not accepted as kwargs by python, see:
-                #http://mail-archives.apache.org/mod_mbox/qpid-dev/200609.mbox/%3C1159389941.4505.10.camel@localhost.localdomain%3E
+            if not PY27:
+                # unicode keys are not accepted as kwargs by python, until 2.7:
+                # http://bugs.python.org/issue2646
                 # So we make a local dict with the same keys but as strings:
                 return datatype(**dict((str(k), v) for (k, v) in value.items()))
             else:
@@ -171,7 +174,7 @@ def get_values(self, *args, **kwargs):
         datatype = kwargs.pop("datatype", None)
         values = self.make_request(*args, **kwargs)
         if datatype:
-            if not PY3K:
+            if not PY27:
                 # Same as above, unicode keys will blow up in **args, so we need to
                 # create a new 'values' dict with string keys
                 return [datatype(**dict((str(k), v) for (k, v) in value.items()))
