Add page parameter for objects supporting a list.

twidi · JNRowe · commit a8125aad2e41 · 2011-10-19T10:21:12.000+01:00
diff --git a/github2/commits.py b/github2/commits.py
@@ -27,7 +27,7 @@ def __repr__(self):
 class Commits(GithubCommand):
     domain = "commits"
 
-    def list(self, project, branch="master", file=None):
+    def list(self, project, branch="master", file=None, page=1):
         """List commits on a project
 
         .. warning::
@@ -38,9 +38,10 @@ def list(self, project, branch="master", file=None):
         :param str project: project name
         :param str branch: branch name, or ``master`` if not given
         :param str file: optional file filter
+        :param int page: optional page number
         """
-        return self.get_values("list", project, branch, file,
-                               filter="commits", datatype=Commit)
+        return self.get_values("list", project, branch, file, filter="commits",
+                               datatype=Commit, page=page)
 
     def show(self, project, sha):
         """Get a specific commit
diff --git a/github2/core.py b/github2/core.py
@@ -135,6 +135,9 @@ def __init__(self, request):
     def make_request(self, command, *args, **kwargs):
         filter = kwargs.get("filter")
         post_data = kwargs.get("post_data") or {}
+        page = kwargs.pop("page", 1)
+        if page and not page == 1:
+            post_data["page"] = page
         method = kwargs.get("method", "GET")
         if method.upper() == "POST" or method.upper() == "GET" and post_data:
             response = self.request.post(self.domain, command, *args,
diff --git a/github2/pull_requests.py b/github2/pull_requests.py
@@ -84,11 +84,12 @@ def show(self, project, number):
         return self.get_value(project, str(number), filter="pull",
                               datatype=PullRequest)
 
-    def list(self, project, state="open"):
+    def list(self, project, state="open", page=1):
         """List all pull requests for a project
 
         :param str project: Github project
         :param str state: can be either ``open`` or ``closed``
+        :param int page: optional page number
         """
         return self.get_values(project, state, filter="pulls",
-                               datatype=PullRequest)
+                               datatype=PullRequest, page=page)
diff --git a/github2/repositories.py b/github2/repositories.py
@@ -62,7 +62,7 @@ def pushable(self):
                                datatype=Repository)
 
 
-    def list(self, user=None):
+    def list(self, user=None, page=1):
         """Return a list of all repositories for a user.
 
         .. deprecated: 0.4.0
@@ -71,10 +71,11 @@ def list(self, user=None):
            brittle and will be removed in a future release!
 
         :param str user: Github user name to list repositories for
+        :param int page: optional page number
         """
         user = user or self.request.username
         return self.get_values("show", user, filter="repositories",
-                               datatype=Repository)
+                               datatype=Repository, page=page)
 
     @requires_auth
     def watch(self, project):
@@ -208,14 +209,15 @@ def watchers(self, project):
         """
         return self.get_values("show", project, "watchers", filter="watchers")
 
-    def watching(self, for_user=None):
+    def watching(self, for_user=None, page=None):
         """Lists all the repos a user is watching
 
         :param str for_user: optional Github user name to list repositories for
+        :param int page: optional page number
         """
         for_user = for_user or self.request.username
         return self.get_values("watched", for_user, filter="repositories",
-                               datatype=Repository)
+                               datatype=Repository, page=page)
 
     def list_contributors(self, project):
         """Lists all the contributors in a project
