minor cleanup in java tests

eugenp · eugenp · commit 00b5f89e87ac · 2014-10-05T17:27:27.000+03:00
diff --git a/core-java/pom.xml b/core-java/pom.xml
@@ -163,7 +163,7 @@
 		<hibernate-validator.version>5.1.2.Final</hibernate-validator.version>
 
 		<!-- util -->
-		<guava.version>17.0</guava.version>
+		<guava.version>17.0</guava.version> <!-- upgrade to 18.0 -->
 		<commons-lang3.version>3.3.2</commons-lang3.version>
 
 		<!-- testing -->
diff --git a/core-java/src/test/java/org/baeldung/java/CoreJavaRandomUnitTest.java b/core-java/src/test/java/org/baeldung/java/CoreJavaRandomUnitTest.java
@@ -1,5 +1,6 @@
 package org.baeldung.java;
 
+import java.nio.charset.Charset;
 import java.util.Random;
 
 import org.apache.commons.lang3.RandomStringUtils;
@@ -151,7 +152,7 @@ public void givenUsingApache_whenGeneratingRandomDoubleBounded_thenCorrect() {
     public void givenUsingPlainJava_whenGeneratingRandomStringUnbounded_thenCorrect() {
         final byte[] array = new byte[7]; // length is bounded by 7
         new Random().nextBytes(array);
-        final String generatedString = new String(array);
+        final String generatedString = new String(array, Charset.forName("UTF-8"));
 
         System.out.println(generatedString);
     }
@@ -166,7 +167,7 @@ public void givenUsingPlainJava_whenGeneratingRandomStringBounded_thenCorrect()
             final int randomLimitedInt = leftLimit + (int) (new Random().nextFloat() * (rightLimit - leftLimit));
             buffer.append((char) randomLimitedInt);
         }
-        final String generatedString = new String(buffer);
+        final String generatedString = buffer.toString();
 
         System.out.println(generatedString);
     }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`package org.baeldung.java;`
`2`	`2`
	`3`	`+import java.nio.charset.Charset;`
`3`	`4`	`import java.util.Random;`
`4`	`5`
`5`	`6`	`import org.apache.commons.lang3.RandomStringUtils;`
`@@ -151,7 +152,7 @@ public void givenUsingApache_whenGeneratingRandomDoubleBounded_thenCorrect() {`
`151`	`152`	`public void givenUsingPlainJava_whenGeneratingRandomStringUnbounded_thenCorrect() {`
`152`	`153`	`final byte[] array = new byte[7]; // length is bounded by 7`
`153`	`154`	`new Random().nextBytes(array);`
`154`		`- final String generatedString = new String(array);`
	`155`	`+ final String generatedString = new String(array, Charset.forName("UTF-8"));`
`155`	`156`
`156`	`157`	`System.out.println(generatedString);`
`157`	`158`	`}`
`@@ -166,7 +167,7 @@ public void givenUsingPlainJava_whenGeneratingRandomStringBounded_thenCorrect()`
`166`	`167`	`final int randomLimitedInt = leftLimit + (int) (new Random().nextFloat() * (rightLimit - leftLimit));`
`167`	`168`	`buffer.append((char) randomLimitedInt);`
`168`	`169`	`}`
`169`		`- final String generatedString = new String(buffer);`
	`170`	`+ final String generatedString = buffer.toString();`
`170`	`171`
`171`	`172`	`System.out.println(generatedString);`
`172`	`173`	`}`