CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException.

Likitha Shetty · Likitha Shetty · commit db91e54bf3c0 · 2014-02-14T17:01:27.000+05:30
diff --git a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
@@ -270,9 +270,11 @@ public VirtualMachineTO implement(VirtualMachineProfile vm) {
             for (NicTO nicTo : sortNicsByDeviceId(to.getNics())) {
                 sbMacSequence.append(nicTo.getMac()).append("|");
             }
-            sbMacSequence.deleteCharAt(sbMacSequence.length() - 1);
-            String bootArgs = to.getBootArgs();
-            to.setBootArgs(bootArgs + " nic_macs=" + sbMacSequence.toString());
+            if (!sbMacSequence.toString().isEmpty()) {
+                sbMacSequence.deleteCharAt(sbMacSequence.length() - 1);
+                String bootArgs = to.getBootArgs();
+                to.setBootArgs(bootArgs + " nic_macs=" + sbMacSequence.toString());
+            }
 
         }
 

Original file line number	Diff line number	Diff line change
`@@ -270,9 +270,11 @@ public VirtualMachineTO implement(VirtualMachineProfile vm) {`
`270`	`270`	`for (NicTO nicTo : sortNicsByDeviceId(to.getNics())) {`
`271`	`271`	`sbMacSequence.append(nicTo.getMac()).append("\|");`
`272`	`272`	`}`
`273`		`- sbMacSequence.deleteCharAt(sbMacSequence.length() - 1);`
`274`		`- String bootArgs = to.getBootArgs();`
`275`		`- to.setBootArgs(bootArgs + " nic_macs=" + sbMacSequence.toString());`
	`273`	`+ if (!sbMacSequence.toString().isEmpty()) {`
	`274`	`+ sbMacSequence.deleteCharAt(sbMacSequence.length() - 1);`
	`275`	`+ String bootArgs = to.getBootArgs();`
	`276`	`+ to.setBootArgs(bootArgs + " nic_macs=" + sbMacSequence.toString());`
	`277`	`+ }`
`276`	`278`
`277`	`279`	`}`
`278`	`280`