Skip to content

Commit 870aa3d

Browse files
pquernary
authored andcommitted
Move evals to extension module.
1 parent ace2be8 commit 870aa3d

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

src/node.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1505,11 +1505,6 @@ static Handle<Value> Binding(const Arguments& args) {
15051505
exports = Object::New();
15061506
modp->register_func(exports);
15071507
binding_cache->Set(module, exports);
1508-
} else if (!strcmp(*module_v, "evals")) {
1509-
exports = Object::New();
1510-
node::Context::Initialize(exports);
1511-
node::Script::Initialize(exports);
1512-
binding_cache->Set(module, exports);
15131508
} else if (!strcmp(*module_v, "natives")) {
15141509
exports = Object::New();
15151510
// Explicitly define native sources.

src/node_extensions.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ NODE_EXT_LIST_ITEM(node_child_process)
66
#ifdef HAVE_OPENSSL
77
NODE_EXT_LIST_ITEM(node_crypto)
88
#endif
9+
NODE_EXT_LIST_ITEM(node_evals)
910
NODE_EXT_LIST_ITEM(node_fs)
1011
NODE_EXT_LIST_ITEM(node_net)
1112
NODE_EXT_LIST_ITEM(node_http_parser)

src/node_script.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,3 +280,12 @@ template <node::Script::EvalInputFlags iFlag,
280280

281281
return result == args.This() ? result : scope.Close(result);
282282
}
283+
284+
void node::InitEvals(Handle<Object> target) {
285+
HandleScope scope;
286+
287+
node::Context::Initialize(target);
288+
node::Script::Initialize(target);
289+
}
290+
291+
NODE_MODULE(node_evals, node::InitEvals);

src/node_script.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,7 @@ class Script : ObjectWrap {
5757
};
5858

5959

60+
void InitEvals(v8::Handle<v8::Object> target);
61+
6062
} // namespace node
6163
#endif // node_script_h

0 commit comments

Comments
 (0)