Draft
Conversation
- Bump utopia-php/database from 5.3.17 to 5.3.19 - Remove invalid (int) cast on tenant sequence in shared tables mode - Fix DSN construction for documentsdb/vectorsdb: filter empty strings from explode(), skip pool filtering when shared tables env vars unset, fail fast when no pool found - Use dedicated mode for separate database pools in getDatabasesDB since shared tables can't work across engines (PostgreSQL integer _tenant vs MongoDB UUID tenant). Auto-init schema on first use. - Add documentsdb/vectorsdb shared tables env vars to CI workflow - Fix testChannelTablesDBRowUpdate race condition with deterministic event drain loop
# Conflicts: # src/Appwrite/Event/Message/Usage.php
…ine migration tests
…apter skips to Databases VectorsDB/DocumentsDB tests
# Conflicts: # src/Appwrite/Platform/Modules/Databases/Http/VectorsDB/Collections/Create.php
Resolve merge conflicts in app/init/resources.php and app/worker.php
caused by the DI container migration (Http::setResource/Server::setResource
to $container->set). Port separate-pool shared tables logic for
getDatabasesDB to the new file locations (request.php and message.php)
with the correct $databaseDSN->getParam('namespace') fix.
…appwrite into bump-database-version2
🔄 PHP-Retry SummaryFlaky tests detected across commits: Commit
|
| Test | Retries | Total Time | Details |
|---|---|---|---|
LegacyConsoleClientTest::testListDocumentsWithCache |
1 | 1.30s | Logs |
LegacyConsoleClientTest::testListDocumentsCacheBustedByAttributeChange |
1 | 1.77s | Logs |
LegacyConsoleClientTest::testCreatedBetween |
1 | 240.48s | Logs |
LegacyCustomClientTest::testListIndexes |
1 | 240.67s | Logs |
LegacyCustomServerTest::testAttributeResponseModels |
1 | 241.61s | Logs |
VectorsDBConsoleClientTest::testGetCollectionLogs |
1 | 9ms | Logs |
DatabasesConsoleClientTest::testGetCollectionLogs |
1 | 10ms | Logs |
Commit c36d434 - 5 flaky tests
| Test | Retries | Total Time | Details |
|---|---|---|---|
LegacyCustomClientTest::testAttributeResponseModels |
1 | 241.88s | Logs |
LegacyTransactionsCustomClientTest::testIncrementDecrementEndpointsWithTransaction |
1 | 240.08s | Logs |
LegacyTransactionsCustomServerTest::testRollback |
1 | 240.43s | Logs |
VectorsDBConsoleClientTest::testGetCollectionLogs |
1 | 12ms | Logs |
DatabasesConsoleClientTest::testGetCollectionLogs |
1 | 15ms | Logs |
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
These tests fail after merging
1.9.x(with feat/migrate-di-container) intobump-database-version2. The DI migration PR only ran MongoDB dedicated tests (27 jobs), never shared-table modes.