Set zip info deterministically

diracdeltas · diracdeltas · commit 51480ad73e9d · 2013-10-02T17:48:35.000-07:00
diff --git a/utils/create_xpi.py b/utils/create_xpi.py
@@ -11,16 +11,32 @@
 with open(exclusionsFile) as f:
     for line in f:
         exclusions.extend(glob.glob(line.strip()))
-print(exclusions)
 
 xpiFile = zipfile.ZipFile(xpiName, mode='w')
 
+def constructZipInfo(filename):
+    """Create deterministic ZIP metadata for a given file"""
+    info = zipfile.ZipInfo(filename, time.gmtime(1378343307))
+    info.compress_type = 0
+    info.comment = ''
+    info.extra = ''
+    info.create_system = 3
+    info.create_version = 20
+    info.extract_version = 20
+    if os.path.isfile(filename):
+        info.external_attr = 0664 << 16L
+    elif os.path.isdir(filename):
+        info.external_attr = 04775 << 16L
+    # info.external_attr = 2176057344L
+    info.volume = 0
+    return info
+
 for root,subfolders,files in os.walk('.'):
     for fi in files:
         filename = os.path.join(root,fi)
         if filename not in map(lambda x: './'+x, exclusions):
-          print(filename)
-          info = zipfile.ZipInfo(filename, time.gmtime(1378343307))
-          xpiFile.writestr(info, '')
+            print("Adding to zip: "+filename)
+            info = constructZipInfo(filename)
+            xpiFile.writestr(info, open(filename).read())
 
 xpiFile.close()
