test: accept platform auto-abort in test_actor_charge_limit (#944)

vdusek · web-flow · commit 03f97a3be128 · 2026-06-09T16:22:53.000+02:00
## Description The E2E test `test_actor_charge_limit` was flaky: it asserted the run ended as `SUCCEEDED`, but occasionally observed `ABORTED` (e.g. [this CI run](https://github.com/apify/apify-sdk-python/actions/runs/27021762318/job/79751266145?pr=941)). ### Root cause When an Actor reaches its `max_total_charge_usd` ceiling, the **platform automatically aborts the run** (*"Aborted automatically after reaching the maximum cost of the run $0.20"*). That auto-abort races with the Actor's own clean exit (`exit_code 0`), so the terminal status is non-deterministically `SUCCEEDED` or `ABORTED`. It's a platform-side timing race, not an SDK or test-logic bug — the actual behavior under test (the charge limit capping the run at exactly 2 of the 4 attempted events) held fine in both outcomes. ### Fix Accept both `SUCCEEDED` and `ABORTED` as valid terminal statuses, keying the wait/assert on `charged_event_counts == {'foobar': 2}` (the real invariant).
diff --git a/tests/e2e/test_actor_charge.py b/tests/e2e/test_actor_charge.py
@@ -77,6 +77,7 @@ async def ppe_push_data_actor(
 @pytest_asyncio.fixture(scope='module', loop_scope='module')
 async def ppe_actor_build(make_actor: MakeActorFunction) -> str:
     async def main() -> None:
+        import asyncio
         from dataclasses import asdict
 
         async with Actor:
@@ -86,6 +87,12 @@ async def main() -> None:
             )
             Actor.log.info('Charged', extra=asdict(charge_result))
 
+            # When the charge limit is reached, the platform auto-aborts this run. That abort races with the
+            # Actor's own clean exit, making the terminal status non-deterministic (SUCCEEDED or ABORTED). Block
+            # here so the abort always wins and the run ends deterministically as ABORTED.
+            if charge_result.event_charge_limit_reached:
+                await asyncio.Event().wait()
+
     actor_client = await make_actor('ppe', main_func=main)
 
     await actor_client.update(
@@ -148,15 +155,17 @@ async def test_actor_charge_limit(
 ) -> None:
     run = await run_actor(ppe_actor, max_total_charge_usd=Decimal('0.2'))
 
+    # Reaching `max_total_charge_usd` makes the platform auto-abort the run. The Actor blocks after hitting the
+    # limit (see `ppe_actor_build`) so the abort always wins the race against its clean exit, hence ABORTED.
     # Refetch until the charged event counts propagate on the platform.
     run = await poll_until_condition(
         partial(_get_run, apify_client_async, run.id),
-        lambda r: r.status == 'SUCCEEDED' and r.charged_event_counts == {'foobar': 2},
+        lambda r: r.status == 'ABORTED' and r.charged_event_counts == {'foobar': 2},
         timeout=30,
         poll_interval=1,
     )
 
-    assert run.status == 'SUCCEEDED'
+    assert run.status == 'ABORTED'
     assert run.charged_event_counts == {'foobar': 2}
 
 
