trace_events: avoid flusing uninitialized traces

ofrobots · ofrobots · commit 90c93682d13e · 2018-09-13T18:07:21.000-07:00
PR-URL: nodejs#22812 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
diff --git a/src/tracing/node_trace_buffer.cc b/src/tracing/node_trace_buffer.cc
@@ -59,7 +59,13 @@ void InternalTraceBuffer::Flush(bool blocking) {
       for (size_t i = 0; i < total_chunks_; ++i) {
         auto& chunk = chunks_[i];
         for (size_t j = 0; j < chunk->size(); ++j) {
-          agent_->AppendTraceEvent(chunk->GetEventAt(j));
+          TraceObject* trace_event = chunk->GetEventAt(j);
+          // Another thread may have added a trace that is yet to be
+          // initialized. Skip such traces.
+          // https://github.com/nodejs/node/issues/21038.
+          if (trace_event->name()) {
+            agent_->AppendTraceEvent(trace_event);
+          }
         }
       }
       total_chunks_ = 0;
