Skip to content

Commit d7cb4e8

Browse files
iamgd67symat
authored andcommitted
ZOOKEEPER-4464: zooinspector display "Ephemeral Owner" in hex for easy match to jmx session
zooinspector now show "Ephemeral Owner" in 10 base number while JMX connections show in hex format. this makes it a little hard to match them. It will be much better if hex format is shown too, I will create a pr add hex format just beside the 10 based one. Author: 67 <67@gd67.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes #1813 from iamgd67/ZOOKEEPER-4464
1 parent a160981 commit d7cb4e8

1 file changed

Lines changed: 16 additions & 1 deletion

File tree

  • zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/gui/nodeviewer

‎zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/org/apache/zookeeper/inspector/gui/nodeviewer/NodeViewerMetaData.java‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ protected void done() {
118118
for (Map.Entry<String, String> entry : data.entrySet()) {
119119
rowPos = 2 * i + 1;
120120
JLabel label = new JLabel(entry.getKey());
121-
JTextField text = new JTextField(entry.getValue());
121+
JTextField text = new JTextField(formatValByKeyType(entry.getKey(),entry.getValue()));
122122
text.setEditable(false);
123123
GridBagConstraints c1 = new GridBagConstraints();
124124
c1.gridx = 0;
@@ -164,6 +164,21 @@ protected void done() {
164164
NodeViewerMetaData.this.metaDataPanel.revalidate();
165165
NodeViewerMetaData.this.metaDataPanel.repaint();
166166
}
167+
168+
private String formatValByKeyType(String key, String value) {
169+
if(key==null) return value;
170+
String formatedVal=value;
171+
switch (key){
172+
case "Ephemeral Owner":
173+
try{
174+
formatedVal = String.format("0x%x", Long.parseLong(value));
175+
}catch (NumberFormatException e){
176+
LoggerFactory.getLogger().warn("parse {}'s value {} to hex fail",key,value,e);
177+
}
178+
break;
179+
}
180+
return formatedVal;
181+
}
167182
};
168183
worker.execute();
169184
}

0 commit comments

Comments
 (0)