Skip to content

Commit 6429741

Browse files
slachiewiczslachiewicz
committed
Drop public from junit tests
1 parent cabb87f commit 6429741

3 files changed

Lines changed: 35 additions & 35 deletions

File tree

‎src/test/java/org/apache/maven/archiver/ManifestConfigurationTest.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,30 +28,30 @@ class ManifestConfigurationTest {
2828
private ManifestConfiguration manifestConfiguration;
2929

3030
@BeforeEach
31-
public void before() {
31+
void before() {
3232
this.manifestConfiguration = new ManifestConfiguration();
3333
}
3434

3535
@Test
36-
public void XXX() {
36+
void XXX() {
3737
assertThat(manifestConfiguration.getClasspathLayoutType())
3838
.isEqualTo(ManifestConfiguration.CLASSPATH_LAYOUT_TYPE_SIMPLE);
3939
}
4040

4141
@Test
42-
public void getClasspathPrefixShouldReturnPrefixWithSlashesInsteadOfBackSlashes() {
42+
void getClasspathPrefixShouldReturnPrefixWithSlashesInsteadOfBackSlashes() {
4343
manifestConfiguration.setClasspathPrefix("\\lib\\const\\");
4444
assertThat(manifestConfiguration.getClasspathPrefix()).isEqualTo("/lib/const/");
4545
}
4646

4747
@Test
48-
public void getClasspathPrefixShouldReturnPrefixWithTraingSlash() {
48+
void getClasspathPrefixShouldReturnPrefixWithTraingSlash() {
4949
manifestConfiguration.setClasspathPrefix("const");
5050
assertThat(manifestConfiguration.getClasspathPrefix()).isEqualTo("const/");
5151
}
5252

5353
@Test
54-
public void getClasspathPrefixShouldReturnTheTrailingSlash() {
54+
void getClasspathPrefixShouldReturnTheTrailingSlash() {
5555
manifestConfiguration.setClasspathPrefix("const/");
5656
assertThat(manifestConfiguration.getClasspathPrefix()).isEqualTo("const/");
5757
}

‎src/test/java/org/apache/maven/archiver/MavenArchiveConfigurationTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class MavenArchiveConfigurationTest {
3434
private MavenArchiveConfiguration archive;
3535

3636
@BeforeEach
37-
public void before() {
37+
void before() {
3838
archive = new MavenArchiveConfiguration();
3939
archive.setManifest(new ManifestConfiguration());
4040
archive.setForced(false);

‎src/test/java/org/apache/maven/archiver/MavenArchiverTest.java‎

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ private MavenArchiver getMavenArchiver(JarArchiver jarArchiver) {
317317
}
318318

319319
@Test
320-
public void testDashesInClassPath_MSHARED_134()
320+
void testDashesInClassPath_MSHARED_134()
321321
throws IOException, ManifestException, DependencyResolutionRequiredException {
322322
File jarFile = new File("target/test/dummyWithDashes.jar");
323323
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
@@ -346,7 +346,7 @@ public void testDashesInClassPath_MSHARED_134()
346346
}
347347

348348
@Test
349-
public void testDashesInClassPath_MSHARED_182()
349+
void testDashesInClassPath_MSHARED_182()
350350
throws IOException, ManifestException, DependencyResolutionRequiredException {
351351
File jarFile = new File("target/test/dummy.jar");
352352
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
@@ -379,7 +379,7 @@ public void testDashesInClassPath_MSHARED_182()
379379
}
380380

381381
@Test
382-
public void testCarriageReturnInManifestEntry() throws Exception {
382+
void testCarriageReturnInManifestEntry() throws Exception {
383383
File jarFile = new File("target/test/dummy.jar");
384384
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
385385

@@ -409,7 +409,7 @@ public void testCarriageReturnInManifestEntry() throws Exception {
409409
}
410410

411411
@Test
412-
public void testDeprecatedCreateArchiveAPI() throws Exception {
412+
void testDeprecatedCreateArchiveAPI() throws Exception {
413413
File jarFile = new File("target/test/dummy.jar");
414414
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
415415

@@ -439,7 +439,7 @@ public void testDeprecatedCreateArchiveAPI() throws Exception {
439439
}
440440

441441
@Test
442-
public void testMinimalManifestEntries() throws Exception {
442+
void testMinimalManifestEntries() throws Exception {
443443
File jarFile = new File("target/test/dummy.jar");
444444
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
445445

@@ -462,7 +462,7 @@ public void testMinimalManifestEntries() throws Exception {
462462
}
463463

464464
@Test
465-
public void testManifestEntries() throws Exception {
465+
void testManifestEntries() throws Exception {
466466
File jarFile = new File("target/test/dummy.jar");
467467
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
468468

@@ -537,7 +537,7 @@ public void testManifestEntries() throws Exception {
537537
}
538538

539539
@Test
540-
public void testManifestWithInvalidAutomaticModuleNameThrowsOnCreateArchive() throws Exception {
540+
void testManifestWithInvalidAutomaticModuleNameThrowsOnCreateArchive() throws Exception {
541541
File jarFile = new File("target/test/dummy.jar");
542542
JarArchiver jarArchiver = getCleanJarArchiver(jarFile);
543543

@@ -562,7 +562,7 @@ public void testManifestWithInvalidAutomaticModuleNameThrowsOnCreateArchive() th
562562
* Test to make sure that manifest sections are present in the manifest prior to the archive has been created.
563563
*/
564564
@Test
565-
public void testManifestSections() throws Exception {
565+
void testManifestSections() throws Exception {
566566
MavenArchiver archiver = new MavenArchiver();
567567

568568
MavenSession session = getDummySession();
@@ -593,7 +593,7 @@ public void testManifestSections() throws Exception {
593593
}
594594

595595
@Test
596-
public void testDefaultClassPathValue() throws Exception {
596+
void testDefaultClassPathValue() throws Exception {
597597
MavenSession session = getDummySession();
598598
MavenProject project = getDummyProject();
599599
File jarFile = new File("target/test/dummy.jar");
@@ -626,7 +626,7 @@ private void deleteAndAssertNotPresent(File jarFile) {
626626
}
627627

628628
@Test
629-
public void testDefaultClassPathValue_WithSnapshot() throws Exception {
629+
void testDefaultClassPathValue_WithSnapshot() throws Exception {
630630
MavenSession session = getDummySession();
631631
MavenProject project = getDummyProjectWithSnapshot();
632632
File jarFile = new File("target/test/dummy.jar");
@@ -655,7 +655,7 @@ public void testDefaultClassPathValue_WithSnapshot() throws Exception {
655655
}
656656

657657
@Test
658-
public void testMavenRepoClassPathValue() throws Exception {
658+
void testMavenRepoClassPathValue() throws Exception {
659659
MavenSession session = getDummySession();
660660
MavenProject project = getDummyProject();
661661
File jarFile = new File("target/test/dummy.jar");
@@ -692,7 +692,7 @@ public void testMavenRepoClassPathValue() throws Exception {
692692
}
693693

694694
@Test
695-
public void shouldCreateArchiveWithSimpleClassPathLayoutWhileSettingSimpleLayoutExplicit() throws Exception {
695+
void shouldCreateArchiveWithSimpleClassPathLayoutWhileSettingSimpleLayoutExplicit() throws Exception {
696696
MavenSession session = getDummySession();
697697
MavenProject project = getDummyProject();
698698
File jarFile = new File("target/test/dummy-explicit-simple.jar");
@@ -724,7 +724,7 @@ public void shouldCreateArchiveWithSimpleClassPathLayoutWhileSettingSimpleLayout
724724
}
725725

726726
@Test
727-
public void shouldCreateArchiveCustomerLayoutSimple() throws Exception {
727+
void shouldCreateArchiveCustomerLayoutSimple() throws Exception {
728728
MavenSession session = getDummySession();
729729
MavenProject project = getDummyProject();
730730
File jarFile = new File("target/test/dummy-custom-layout-simple.jar");
@@ -757,7 +757,7 @@ public void shouldCreateArchiveCustomerLayoutSimple() throws Exception {
757757
}
758758

759759
@Test
760-
public void shouldCreateArchiveCustomLayoutSimpleNonUnique() throws Exception {
760+
void shouldCreateArchiveCustomLayoutSimpleNonUnique() throws Exception {
761761
MavenSession session = getDummySession();
762762
MavenProject project = getDummyProject();
763763
File jarFile = new File("target/test/dummy-custom-layout-simple-non-unique.jar");
@@ -791,7 +791,7 @@ public void shouldCreateArchiveCustomLayoutSimpleNonUnique() throws Exception {
791791
}
792792

793793
@Test
794-
public void shouldCreateArchiveCustomLayoutRepository() throws Exception {
794+
void shouldCreateArchiveCustomLayoutRepository() throws Exception {
795795
MavenSession session = getDummySession();
796796
MavenProject project = getDummyProject();
797797
File jarFile = new File("target/test/dummy-custom-layout-repo.jar");
@@ -831,7 +831,7 @@ public void shouldCreateArchiveCustomLayoutRepository() throws Exception {
831831
}
832832

833833
@Test
834-
public void shouldCreateArchiveCustomLayoutRepositoryNonUnique() throws Exception {
834+
void shouldCreateArchiveCustomLayoutRepositoryNonUnique() throws Exception {
835835
MavenSession session = getDummySession();
836836
MavenProject project = getDummyProject();
837837
File jarFile = new File("target/test/dummy-custom-layout-repo-non-unique.jar");
@@ -871,7 +871,7 @@ public void shouldCreateArchiveCustomLayoutRepositoryNonUnique() throws Exceptio
871871
}
872872

873873
@Test
874-
public void shouldCreateArchiveWithSimpleClassPathLayoutUsingDefaults() throws Exception {
874+
void shouldCreateArchiveWithSimpleClassPathLayoutUsingDefaults() throws Exception {
875875
MavenSession session = getDummySession();
876876
MavenProject project = getDummyProject();
877877
File jarFile = new File("target/test/dummy-defaults.jar");
@@ -901,7 +901,7 @@ public void shouldCreateArchiveWithSimpleClassPathLayoutUsingDefaults() throws E
901901
}
902902

903903
@Test
904-
public void testMavenRepoClassPathValue_WithSnapshot() throws Exception {
904+
void testMavenRepoClassPathValue_WithSnapshot() throws Exception {
905905
MavenSession session = getDummySession();
906906
MavenProject project = getDummyProjectWithSnapshot();
907907
File jarFile = new File("target/test/dummy.jar");
@@ -938,7 +938,7 @@ public void testMavenRepoClassPathValue_WithSnapshot() throws Exception {
938938
}
939939

940940
@Test
941-
public void testCustomClassPathValue() throws Exception {
941+
void testCustomClassPathValue() throws Exception {
942942
MavenSession session = getDummySession();
943943
MavenProject project = getDummyProject();
944944
File jarFile = new File("target/test/dummy.jar");
@@ -978,7 +978,7 @@ public void testCustomClassPathValue() throws Exception {
978978
}
979979

980980
@Test
981-
public void testCustomClassPathValue_WithSnapshotResolvedVersion() throws Exception {
981+
void testCustomClassPathValue_WithSnapshotResolvedVersion() throws Exception {
982982
MavenSession session = getDummySession();
983983
MavenProject project = getDummyProjectWithSnapshot();
984984
File jarFile = new File("target/test/dummy.jar");
@@ -1017,7 +1017,7 @@ public void testCustomClassPathValue_WithSnapshotResolvedVersion() throws Except
10171017
}
10181018

10191019
@Test
1020-
public void testCustomClassPathValue_WithSnapshotForcingBaseVersion() throws Exception {
1020+
void testCustomClassPathValue_WithSnapshotForcingBaseVersion() throws Exception {
10211021
MavenSession session = getDummySession();
10221022
MavenProject project = getDummyProjectWithSnapshot();
10231023
File jarFile = new File("target/test/dummy.jar");
@@ -1054,7 +1054,7 @@ public void testCustomClassPathValue_WithSnapshotForcingBaseVersion() throws Exc
10541054
}
10551055

10561056
@Test
1057-
public void testDefaultPomProperties() throws Exception {
1057+
void testDefaultPomProperties() throws Exception {
10581058
MavenSession session = getDummySession();
10591059
MavenProject project = getDummyProject();
10601060
File jarFile = new File("target/test/dummy.jar");
@@ -1088,7 +1088,7 @@ public void testDefaultPomProperties() throws Exception {
10881088
}
10891089

10901090
@Test
1091-
public void testCustomPomProperties() throws Exception {
1091+
void testCustomPomProperties() throws Exception {
10921092
MavenSession session = getDummySession();
10931093
MavenProject project = getDummyProject();
10941094
File jarFile = new File("target/test/dummy.jar");
@@ -1356,7 +1356,7 @@ public Manifest getJarFileManifest(File jarFile) throws IOException {
13561356
}
13571357

13581358
@Test
1359-
public void testParseOutputTimestamp() {
1359+
void testParseOutputTimestamp() {
13601360
MavenArchiver archiver = new MavenArchiver();
13611361

13621362
assertThat(archiver.parseOutputTimestamp(null)).isNull();
@@ -1393,7 +1393,7 @@ public void testParseOutputTimestamp() {
13931393
@ParameterizedTest
13941394
@NullAndEmptySource
13951395
@ValueSource(strings = {".", " ", "_", "-", "T", "/", "!", "!", "*", "ñ"})
1396-
public void testEmptyParseOutputTimestampInstant(String value) {
1396+
void testEmptyParseOutputTimestampInstant(String value) {
13971397
// Empty optional if null or 1 char
13981398
assertThat(MavenArchiver.parseBuildOutputTimestamp(value)).isEmpty();
13991399
}
@@ -1413,7 +1413,7 @@ public void testEmptyParseOutputTimestampInstant(String value) {
14131413
"1980-01-01T00:00:02Z,315532802",
14141414
"2099-12-31T23:59:59Z,4102444799"
14151415
})
1416-
public void testParseOutputTimestampInstant(String value, long expected) {
1416+
void testParseOutputTimestampInstant(String value, long expected) {
14171417
assertThat(MavenArchiver.parseBuildOutputTimestamp(value)).contains(Instant.ofEpochSecond(expected));
14181418
}
14191419

@@ -1428,7 +1428,7 @@ public void testParseOutputTimestampInstant(String value, long expected) {
14281428
"Tue, 3 Jun 2008 11:05:30 GMT",
14291429
"2011-12-03T10:15:30+01:00[Europe/Paris]"
14301430
})
1431-
public void testThrownParseOutputTimestampInstant(String outputTimestamp) {
1431+
void testThrownParseOutputTimestampInstant(String outputTimestamp) {
14321432
// Invalid parsing
14331433
assertThatExceptionOfType(IllegalArgumentException.class)
14341434
.isThrownBy(() -> MavenArchiver.parseBuildOutputTimestamp(outputTimestamp))
@@ -1445,7 +1445,7 @@ public void testThrownParseOutputTimestampInstant(String outputTimestamp) {
14451445
"1980-01-01T00:15:35+01:00",
14461446
"1980-01-01T10:15:35+14:00"
14471447
})
1448-
public void testThrownParseOutputTimestampInvalidRange(String outputTimestamp) {
1448+
void testThrownParseOutputTimestampInvalidRange(String outputTimestamp) {
14491449
// date is not within the valid range 1980-01-01T00:00:02Z to 2099-12-31T23:59:59Z
14501450
assertThatExceptionOfType(IllegalArgumentException.class)
14511451
.isThrownBy(() -> MavenArchiver.parseBuildOutputTimestamp(outputTimestamp))
@@ -1460,7 +1460,7 @@ public void testThrownParseOutputTimestampInvalidRange(String outputTimestamp) {
14601460
"1988-02-22T20:37:42+06,572539062"
14611461
})
14621462
@EnabledForJreRange(min = JRE.JAVA_9)
1463-
public void testShortOffset(String value, long expected) {
1463+
void testShortOffset(String value, long expected) {
14641464
assertThat(MavenArchiver.parseBuildOutputTimestamp(value)).contains(Instant.ofEpochSecond(expected));
14651465
}
14661466
}

0 commit comments

Comments
 (0)