Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/datasketches-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: apache/datasketches-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bloom-filter-bindings
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 5 files changed
  • 2 contributors

Commits on Aug 8, 2025

  1. Configuration menu
    Copy the full SHA
    65e1f1d View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2025

  1. Fix bloom filter serialize method binding - Remove syntax error in C+…

    …+ wrapper and add serialize test
    c-dickens committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    e49f685 View commit details
    Browse the repository at this point in the history
  2. Added get_serialized_bytes

    c-dickens committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    b118463 View commit details
    Browse the repository at this point in the history
  3. Refactor bloom filter API to use static factory methods instead of st…

    …andalone function
    
    - Replace create_bloom_filter() function with bloom_filter.create_by_accuracy() and bloom_filter.create_by_size() static methods
    - Follow repository vernacular pattern similar to other sketches
    - Update tests to use new API
    - Fix indentation issues in test file
    - All tests passing (4/4 bloom filter tests, 37/37 other tests)
    c-dickens committed Aug 10, 2025
    Configuration menu
    Copy the full SHA
    f074b98 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2025

  1. Add reset method to bloom filter bindings

    - Add reset() method to Python bloom filter wrapper
    - Method clears all bits and resets filter to empty state
    - Preserves filter configuration (capacity, num_hashes, seed)
    - Add comprehensive unit test for reset functionality
    - Test verifies empty state, bit usage reset, and post-reset operations
    c-dickens committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    ffe1039 View commit details
    Browse the repository at this point in the history
  2. Add multi-type support to bloom filter bindings

    - Add efficient overloads for different Python data types:
      * uint64_t for non-negative integers
      * int64_t for negative/positive integers
      * double for floats
      * std::string for strings
      * bytes objects for binary data
    - Use proper static_cast syntax for nanobind compatibility
    - Add comprehensive unit test for all supported data types
    - Remove memoryview support (not available in nanobind)
    - All 16 bloom filter tests pass
    c-dickens committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    2f3a62b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e0fa4e1 View commit details
    Browse the repository at this point in the history
  4. Added string output

    c-dickens committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    95b556a View commit details
    Browse the repository at this point in the history
  5. Fix bloom filter inversion test and improve wrapper documentation

    - Fix bloom filter inversion test to use correct mathematical properties
    - Replace probabilistic expectation for new items after inversion with double-inversion test
    - Test that invert(invert(filter)) == filter, which is mathematically guaranteed
    - Update invert() method documentation to match C++ implementation
    - Add __repr__ method for better debugging and REPL experience
    c-dickens committed Aug 11, 2025
    Configuration menu
    Copy the full SHA
    c3b3ccd View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2025

  1. Configuration menu
    Copy the full SHA
    d4b3700 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2026

  1. Merge pull request #62 from c-dickens/bloom-filter-bindings

    Bloom filter bindings
    leerho authored Jan 20, 2026
    Configuration menu
    Copy the full SHA
    cc6503e View commit details
    Browse the repository at this point in the history
Loading