Refresh statistics parser settings between query files - #24738
Draft
EltonChang1 wants to merge 1 commit into
Draft
Refresh statistics parser settings between query files#24738EltonChang1 wants to merge 1 commit into
EltonChang1 wants to merge 1 commit into
Conversation
Signed-off-by: Elton Chang <tchang52@ucsc.edu>
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24738 +/- ##
==========================================
+ Coverage 81.42% 81.45% +0.02%
==========================================
Files 1121 1121
Lines 402142 402211 +69
Branches 402142 402211 +69
==========================================
+ Hits 327460 327633 +173
+ Misses 55484 55373 -111
- Partials 19198 19205 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The statistics runner previously captured SQL parser settings only once. A successful
SETin one query file therefore changed the session but did not affect parsing of later files, which made ordered query suites behave inconsistently with session state.What changes are included in this PR?
Are these changes tested?
cargo test -p datafusion-benchmarks --lib statistics::tests -- --nocapture(7 passed)cargo test -p datafusion-benchmarks --lib 'statistics::tests::refreshes_' -- --nocaptureafter rebasing (2 passed)cargo check -p datafusion-benchmarks --libcargo clippy -p datafusion-benchmarks --lib -- -D warningscargo fmt --all -- --checkThe broader
cargo clippy -p datafusion-benchmarks --all-targets --all-features -- -D warningscould not complete locally because the optionalsnmalloctarget requirescmake, which is unavailable in this environment. It produced no Rust diagnostics before that build-tool failure.Are there any user-facing changes?
Yes. Parser settings changed by an earlier statistics query file now apply when later query files are parsed. There are no public API changes.
This draft was prepared with AI assistance and has not yet received human review. I understand the implementation end-to-end; there are no known design assumptions beyond the documented same-file parsing limitation.