Chore: Fix TPC-DS schema/query (fixes q30 run) (#22086)

Dandandan · blaginin · web-flow · commit 3d06bedcc9af · 2026-05-11T07:10:47.000Z
## Which issue does this PR close?

- Closes #.

## Rationale for this change

TPC-DS query 30 failed in the benchmark because the query referenced
`c_last_review_date`, while the SF1 parquet benchmark schema exposes the
customer review date key as `c_last_review_date_sk`.

This was updated in newer tpcds spec.

The query that uses the column now succeeds:
```
│ QQuery 30 │                                  FAIL │        30.38 / 30.73 ±0.34 / 31.34 ms │  incomparable │
```


## What changes are included in this PR?

This updates query 30 to use `c_last_review_date_sk` and aligns the
TPC-DS planning test schema with the benchmark parquet schema.

## Are these changes tested?


## Are there any user-facing changes?

No. This fixes a benchmark query/schema mismatch.

Co-authored-by: Dmitrii Blaginin &lt;dmitrii@blaginin.me&gt;
diff --git a/datafusion/core/tests/tpc-ds/30.sql b/datafusion/core/tests/tpc-ds/30.sql
@@ -14,7 +14,7 @@ with customer_total_return as
          ,ca_state)
   select  c_customer_id,c_salutation,c_first_name,c_last_name,c_preferred_cust_flag
        ,c_birth_day,c_birth_month,c_birth_year,c_birth_country,c_login,c_email_address
-       ,c_last_review_date,ctr_total_return
+       ,c_last_review_date_sk,ctr_total_return
  from customer_total_return ctr1
      ,customer_address
      ,customer
@@ -26,7 +26,6 @@ with customer_total_return as
        and ctr1.ctr_customer_sk = c_customer_sk
  order by c_customer_id,c_salutation,c_first_name,c_last_name,c_preferred_cust_flag
                   ,c_birth_day,c_birth_month,c_birth_year,c_birth_country,c_login,c_email_address
-                  ,c_last_review_date,ctr_total_return
+                  ,c_last_review_date_sk,ctr_total_return
 limit 100;
 
-
diff --git a/test-utils/src/tpcds.rs b/test-utils/src/tpcds.rs
@@ -299,7 +299,7 @@ pub fn tpcds_schemas() -> Vec<TableDef> {
                 Field::new("c_birth_country", DataType::Utf8, false),
                 Field::new("c_login", DataType::Utf8, false),
                 Field::new("c_email_address", DataType::Utf8, false),
-                Field::new("c_last_review_date", DataType::Utf8, false),
+                Field::new("c_last_review_date_sk", DataType::Int32, false),
             ]),
         ),
         TableDef::new(
