Fix import network filtering for account and project scope - #13836
Draft
andrijapanicsb wants to merge 1 commit into
Draft
Fix import network filtering for account and project scope#13836andrijapanicsb wants to merge 1 commit into
andrijapanicsb wants to merge 1 commit into
Conversation
Signed-off-by: andrijapanicsb <andrija.panic@gmail.com>
Contributor
Author
|
@andrijapanicsb a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13836 +/- ##
============================================
+ Coverage 17.69% 17.70% +0.01%
+ Complexity 15835 15831 -4
============================================
Files 5925 5925
Lines 533539 533581 +42
Branches 65274 65282 +8
============================================
+ Hits 94427 94495 +68
+ Misses 428435 428396 -39
- Partials 10677 10690 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Contributor
Author
|
Simulator is 4.21, no support for KVM migration screens/operations |
Contributor
Author
|
@ACSHomeBot package |
Packaging results (commit 35813af)
Package artifacts were retained locally, but no public repository was promoted. Error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12685.
The unmanaged instance import wizard now lists networks in the ownership scope selected by the root administrator and cannot retain a network mapping from a previously selected owner.
This is a focused
4.22-based replacement for the project-network fix attempted in #12854. It contains only the two affected UI components and their unit tests, without the unrelated backend, schema, packaging, or formatting changes currently present in that PR.Problems
The existing import wizard has four related owner-scope problems:
ImportUnmanagedInstanceexposes a project selector but does not passprojectidtoMultiNetworkSelection. Consequently,listNetworksruns without the selected project and project networks are not listed, as reported for 4.22.0 in UI: Import VM wizard doesn't list the project networks #12685.Changes
projectidintoMultiNetworkSelection.listNetworksowner parameters:projectidfor project imports;domainidandaccountfor account imports;User impact
When a root administrator imports an unmanaged instance:
The API remains the authorization boundary; this change makes the UI use the selected target scope consistently and prevents submission of stale UI mappings.
Validation
MultiNetworkSelection.spec.js: five tests covering account/domain parameters, project precedence, domain refresh, clearing an account and stale mapping, and out-of-order responses.ImportUnmanagedInstance.spec.js: two tests covering mutually exclusive account/domain/project transitions and NIC mapping reset.git diff --check: passed.The project-network failure is reported against a live 4.22.0 environment in #12685. The additional stale-state and request-order cases are verified deterministically by the new unit tests; this PR does not claim a separate live 4.22 deployment test.