Skip to content

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps#13380

Draft
Pearl1594 wants to merge 1 commit into
4.22from
update-dbtype-nwrate
Draft

Update nw_rate & mc_rate to int unsigned to allow rates > 65Gbps#13380
Pearl1594 wants to merge 1 commit into
4.22from
update-dbtype-nwrate

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR fixes: #13355

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 requested a review from weizhouapache June 8, 2026 19:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2026

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (21b2025) to head (6a1355a).

Files with missing lines Patch % Lines
...ava/com/cloud/upgrade/dao/Upgrade42210to42220.java 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #13380   +/-   ##
=========================================
  Coverage     17.67%   17.67%           
- Complexity    15792    15793    +1     
=========================================
  Files          5922     5923    +1     
  Lines        533165   533182   +17     
  Branches      65208    65209    +1     
=========================================
+ Hits          94242    94249    +7     
- Misses       428276   428287   +11     
+ Partials      10647    10646    -1     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <29.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
19.4% Coverage on New Code (required ≥ 40%)
45.1% Duplication on New Code (required ≤ 10%)
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE


@Override
public String[] getUpgradableVersionRange() {
return new String[] {"4.22.1.0", "4.22.2.0"};

@Override
public String[] getUpgradableVersionRange() {
return new String[] {"4.22.1.0", "4.22.2.0"};

@Override
public String getUpgradedVersion() {
return "4.22.2.0";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants