Fix ssvm migrate stg net#13379
Conversation
…etworks with dedicated vlan
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13379 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
+ Complexity 13434 13433 -1
============================================
Files 5666 5666
Lines 500645 500649 +4
Branches 60801 60804 +3
============================================
- Hits 81426 81419 -7
- Misses 410112 410121 +9
- Partials 9107 9109 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR targets KVM SSVM live migration failures when the storage network uses a dedicated VLAN by ensuring the destination host creates the storage VLAN bridge during migration/network preparation, even when the NIC’s broadcastType is not Storage but the broadcastUri scheme indicates storage.
Changes:
- Update
BridgeVifDriver#createStorageVnetBridgeIfNeededto detect storage networks viabroadcastUrischeme (storage://...) in addition tobroadcastType == Storage. - Avoid the previous early-return behavior that skipped bridge creation when
broadcastTypewasn’tStorage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (nic.getBroadcastUri() == null) { | ||
| return storageBrName; | ||
| } | ||
|
|
||
| boolean isStorageBroadcast = Networks.BroadcastDomainType.Storage.equals(nic.getBroadcastType()) || | ||
| Networks.BroadcastDomainType.Storage.equals(Networks.BroadcastDomainType.getSchemeValue(nic.getBroadcastUri())); | ||
| if (!isStorageBroadcast) { | ||
| return storageBrName; | ||
| } |
Description
This PR fixes: #13378
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?