Skip to content

server: exclude webserver/apache2 check in VPC VR without tiers#13219

Draft
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-vpc-vr-exclude-apache2-check
Draft

server: exclude webserver/apache2 check in VPC VR without tiers#13219
weizhouapache wants to merge 1 commit into
apache:4.22from
weizhouapache:4.22-vpc-vr-exclude-apache2-check

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented May 22, 2026

Description

This PR refactores #11190

logs show apache2 service is excluded in the router health check

2026-05-22 08:51:37,940 DEBUG [c.c.a.t.Request] (RouterStatusMonitor-1:[ctx-0aaf1866]) (logid:9c7a5c66) Seq 1-2002412984319607143: Sending { Cmd , MgmtId: 32985902482535, via: 1(ref-trl-10000-k-Mu24-wei-zhou-kvm1), Ver: v1, Flags: 100011, [{"com.cloud.agent.api.routing.SetMonitorServiceCommand":{"healthChecksConfig":{"gateways":"gatewaysIps=169.254.0.1 10.0.48.1 ","portForwarding":"","systemThresholds":"minDiskNeeded=100.0,maxCpuUsage=100.0,maxMemoryUsage=100.0;","haproxyData":"","virtualMachines":"","routerVersion":"templateVersion=Cloudstack Release 4.22.0 Fri Oct 3 08:20:09 AM UTC 2025,scriptsVersion=8c8bf4fd7c7c39084206d0a9b1c27612d41bc019d98b722aa7bacfc4245c01e6191a9c8c98457e2740f072139ee9bbab3ee8c59e5e59701617c296807c96ab10"},"reconfigureAfterUpdate":"true","deleteFromProcessedCache":"true","accessDetails":{"router.name":"r-610-VM","router.health.checks.advanced.interval":"10","router.health.checks.enabled":"true","router.health.checks.basic.interval":"3","router.health.checks.excluded":"apache2","router.ip":"169.254.222.103"},"wait":"0","bypassHostMaintenance":"false"}}] }

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (d1e1aa5) to head (73f4929).

Files with missing lines Patch % Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13219      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
- Complexity    15791    15792       +1     
============================================
  Files          5922     5922              
  Lines        533127   533130       +3     
  Branches      65205    65207       +2     
============================================
- Hits          94243    94242       -1     
- Misses       428239   428241       +2     
- Partials      10645    10647       +2     
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17985

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VR Healthcheck Fails when a VPC is created, but there are no VMs created in the VPC yet.

2 participants