Skip to content

Don't allow adding of existing host to another zone, pod or cluster#13182

Draft
vishesh92 wants to merge 1 commit into
apache:4.20from
shapeblue:fix-add-host-diff-location
Draft

Don't allow adding of existing host to another zone, pod or cluster#13182
vishesh92 wants to merge 1 commit into
apache:4.20from
shapeblue:fix-add-host-diff-location

Conversation

@vishesh92
Copy link
Copy Markdown
Member

Description

This PR fixes #13080

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (a7c2a05) to head (6bf5881).

Files with missing lines Patch % Lines
...n/java/com/cloud/resource/ResourceManagerImpl.java 75.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13182      +/-   ##
============================================
- Coverage     16.27%   16.26%   -0.01%     
- Complexity    13440    13441       +1     
============================================
  Files          5665     5665              
  Lines        500555   500571      +16     
  Branches      60789    60793       +4     
============================================
- Hits          81445    81429      -16     
- Misses       410004   410031      +27     
- Partials       9106     9111       +5     
Flag Coverage Δ
uitests 4.15% <ø> (ø)
unittests 17.12% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92 vishesh92 force-pushed the fix-add-host-diff-location branch from 2f64bcd to 6bf5881 Compare May 18, 2026 12:06
@apache apache deleted a comment from blueorangutan May 18, 2026
@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants