ISSUE TYPE

• Bug Report

COMPONENT NAME

• Secondary storage pool / SSVM

CLOUDSTACK VERSION

• Any

CONFIGURATION

• Any

OS / ENVIRONMENT

• N/A

SUMMARY

• Secondary storage pools should in theory not be considered for template / volume / ISO / snapshot upload if percentage utilisation is > 90%
• However if no other pool exist < 90% then the first available secondary pool will be chosen and the 90% utilisation limit ignored.
• This results in secondary storage pools potentially filling up until copy process fails, potentially leading to data loss
• In the following line secondary pools below 90% utilisation are returned:
  

  cloudstack/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java

  Line 155 in 1d05fea

  if (_statsCollector.imageStoreHasEnoughCapacity(imageStore)) {

• However if no secondary storage pool exists <90% then the first secondary storage pool is still picked:

  cloudstack/engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java

  Line 160 in 1d05fea

  return imageStores.get(0);

STEPS TO REPRODUCE

• Create zone with single secondary pool and fill this to above 90%
• Try to upload template / ISO / volume and observe this succeeding

EXPECTED RESULTS

• Upload process should gracefully fail.

ACTUAL RESULTS

• Upload process allows for upload to happen above 90% utilisation