CLOUDSTACK-4780: Changes related to checking snapshot path

Gaurav Aradhye · Girish Shilamkar · commit a160b46cd47a · 2013-12-23T17:58:51.000+05:30
on NFS server, also made marvin import paths specific
diff --git a/test/integration/component/test_add_remove_network.py b/test/integration/component/test_add_remove_network.py
@@ -42,17 +42,17 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
                                         list_virtual_machines,
                                         list_events,
                                         list_zones,
                                         get_free_vlan,
-                                        get_hypervisor_type,
                                         update_resource_limit
                                         )
 
 from marvin.integration.lib.utils import (validateList,
-					                      random_gen)
+					                      random_gen,
+                                          get_hypervisor_type,
+                                          cleanup_resources)
 
 from marvin.cloudstackAPI import (addNicToVirtualMachine,
                                   removeNicFromVirtualMachine,
diff --git a/test/integration/component/test_assign_vm.py b/test/integration/component/test_assign_vm.py
@@ -32,12 +32,12 @@
 from marvin.integration.lib.common import (get_domain,
                                            get_zone,
                                            get_template,
-                                           cleanup_resources,
                                            list_volumes,
                                            update_resource_limit,
                                            list_networks,
                                            list_snapshots,
                                            list_virtual_machines)
+from marvin.integration.lib.utils import cleanup_resources
 
 def log_test_exceptions(func):
     def test_wrap_exception_log(self, *args, **kwargs):
diff --git a/test/integration/component/test_cpu_domain_limits.py b/test/integration/component/test_cpu_domain_limits.py
@@ -30,10 +30,10 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
                                         find_suitable_host,
                                         get_resource_type
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 class Services:
     """Test resource limit services
diff --git a/test/integration/component/test_cpu_limits.py b/test/integration/component/test_cpu_limits.py
@@ -30,10 +30,10 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
                                         find_suitable_host,
                                         get_resource_type
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 
 class Services:
diff --git a/test/integration/component/test_cpu_max_limits.py b/test/integration/component/test_cpu_max_limits.py
@@ -30,9 +30,9 @@
                                         )
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
-                                        get_template,
-                                        cleanup_resources
+                                        get_template
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 class Services:
     """Test resource limit services
diff --git a/test/integration/component/test_cpu_project_limits.py b/test/integration/component/test_cpu_project_limits.py
@@ -30,10 +30,10 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
                                         find_suitable_host,
                                         get_resource_type
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 class Services:
     """Test resource limit services
diff --git a/test/integration/component/test_egress_fw_rules.py b/test/integration/component/test_egress_fw_rules.py
@@ -35,8 +35,8 @@
                                            rebootRouter,
                                            list_routers,
                                            wait_for_cleanup,
-                                           cleanup_resources,
                                            list_virtual_machines)
+from marvin.integration.lib.utils import cleanup_resources
 from marvin.cloudstackAPI.createEgressFirewallRule import createEgressFirewallRuleCmd
 from marvin.cloudstackAPI.deleteEgressFirewallRule import deleteEgressFirewallRuleCmd
 
diff --git a/test/integration/component/test_haproxy.py b/test/integration/component/test_haproxy.py
@@ -34,9 +34,9 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
                                         random_gen
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 from marvin.cloudstackAPI import createLBStickinessPolicy
 from marvin.sshClient import SshClient
 
diff --git a/test/integration/component/test_mm_domain_limits.py b/test/integration/component/test_mm_domain_limits.py
@@ -29,12 +29,12 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
 					                    wait_for_cleanup,
                                         find_suitable_host,
                                         get_resource_type,
                                         update_resource_count
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 class Services:
     """Test memory resource limit services
diff --git a/test/integration/component/test_mm_max_limits.py b/test/integration/component/test_mm_max_limits.py
@@ -29,9 +29,9 @@
                                         )
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
-                                        get_template,
-                                        cleanup_resources
+                                        get_template
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 class Services:
     """Test memory resource limit services
diff --git a/test/integration/component/test_mm_project_limits.py b/test/integration/component/test_mm_project_limits.py
@@ -29,11 +29,11 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
 					                    wait_for_cleanup,
                                         find_suitable_host,
                                         get_resource_type
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 class Services:
     """Test memory resource limit services
diff --git a/test/integration/component/test_snapshots.py b/test/integration/component/test_snapshots.py
@@ -36,12 +36,13 @@
                                              list_snapshots,
                                              list_templates,
                                              list_virtual_machines,
-                                             get_hypervisor_type)
+                                             )
 
 from marvin.integration.lib.utils import    (cleanup_resources,
                                              format_volume_to_ext3,
                                              random_gen,
-                                             is_snapshot_on_nfs)
+                                             is_snapshot_on_nfs,
+                                             get_hypervisor_type)
 
 from marvin.cloudstackAPI import            detachVolume
 import time
diff --git a/test/integration/component/test_vpc_network_lbrules.py b/test/integration/component/test_vpc_network_lbrules.py
@@ -18,11 +18,8 @@
 """ Component tests for VPC network functionality - Load Balancing Rules
 """
 #Import Local Modules
-#import marvin
 from nose.plugins.attrib import attr
 from marvin.cloudstackTestCase import cloudstackTestCase, unittest
-#from marvin.cloudstackAPI import
-#from marvin.integration.lib.utils import
 from marvin.integration.lib.base import (stopRouter,
                                         startRouter,
                                         Account,
@@ -40,8 +37,8 @@
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
                                         get_template,
-                                        cleanup_resources,
                                         list_routers)
+from marvin.integration.lib.utils import cleanup_resources
 import socket
 import time
 
diff --git a/test/integration/component/test_vpc_network_pfrules.py b/test/integration/component/test_vpc_network_pfrules.py
@@ -20,24 +20,23 @@
 from nose.plugins.attrib import attr
 from marvin.cloudstackTestCase import cloudstackTestCase, unittest
 from marvin.integration.lib.base import (stopRouter,
-                                                    startRouter,
-                                                    Account,
-                                                    VpcOffering,
-                                                    VPC,
-                                                    ServiceOffering,
-                                                    NATRule,
-                                                    NetworkACL,
-                                                    PublicIPAddress,
-                                                    NetworkOffering,
-                                                    Network,
-                                                    VirtualMachine,
-                                                    LoadBalancerRule,
-                                                    StaticNATRule)
+                                         startRouter,
+                                         Account,
+                                         VpcOffering,
+                                         VPC,
+                                         ServiceOffering,
+                                         NATRule,
+                                         NetworkACL,
+                                         PublicIPAddress,
+                                         NetworkOffering,
+                                         Network,
+                                         VirtualMachine,
+                                         LoadBalancerRule)
 from marvin.integration.lib.common import (get_domain,
-                                                        get_zone,
-                                                        get_template,
-                                                        cleanup_resources,
-                                                        list_routers)
+                                           get_zone,
+                                           get_template,
+                                           list_routers)
+from marvin.integration.lib.utils import cleanup_resources
 import socket
 import time
 
diff --git a/test/integration/component/test_vpc_network_staticnatrule.py b/test/integration/component/test_vpc_network_staticnatrule.py
@@ -19,25 +19,24 @@
 """
 from nose.plugins.attrib import attr
 from marvin.cloudstackTestCase import cloudstackTestCase, unittest
-from marvin.integration.lib.base import (stopRouter,
-                                                    startRouter,
-                                                    Account,
-                                                    VpcOffering,
-                                                    VPC,
-                                                    ServiceOffering,
-                                                    NATRule,
-                                                    NetworkACL,
-                                                    PublicIPAddress,
-                                                    NetworkOffering,
-                                                    Network,
-                                                    VirtualMachine,
-                                                    LoadBalancerRule,
-                                                    StaticNATRule)
+from marvin.integration.lib.base import (Account,
+                                         VpcOffering,
+                                         VPC,
+                                         ServiceOffering,
+                                         NetworkACL,
+                                         PublicIPAddress,
+                                         NetworkOffering,
+                                         Network,
+                                         VirtualMachine,
+                                         LoadBalancerRule,
+                                         StaticNATRule)
+from marvin.cloudstackAPI import (stopRouter,
+                                  startRouter)
 from marvin.integration.lib.common import (get_domain,
-                                                        get_zone,
-                                                        get_template,
-                                                        cleanup_resources,
-                                                        list_routers)
+                                           get_zone,
+                                           get_template,
+                                           list_routers)
+from marvin.integration.lib.utils import cleanup_resources
 import socket
 import time
 
diff --git a/test/integration/component/test_vpn_users.py b/test/integration/component/test_vpn_users.py
@@ -33,9 +33,9 @@
                                         )
 from marvin.integration.lib.common import (get_domain,
                                         get_zone,
-                                        get_template,
-                                        cleanup_resources,
+                                        get_template
                                         )
+from marvin.integration.lib.utils import cleanup_resources
 
 
 class Services:
diff --git a/tools/marvin/marvin/integration/lib/common.py b/tools/marvin/marvin/integration/lib/common.py
@@ -18,11 +18,56 @@
 """
 
 #Import Local Modules
-from marvin.cloudstackAPI import *
+from marvin.cloudstackAPI import (listConfigurations,
+                                  listPhysicalNetworks,
+                                  listRegions,
+                                  addNetworkServiceProvider,
+                                  updateNetworkServiceProvider,
+                                  listDomains,
+                                  listZones,
+                                  listPods,
+                                  listOsTypes,
+                                  listTemplates,
+                                  updateResourceLimit,
+                                  listRouters,
+                                  listNetworks,
+                                  listClusters,
+                                  listSystemVms,
+                                  listStoragePools,
+                                  listVirtualMachines,
+                                  listLoadBalancerRuleInstances,
+                                  listFirewallRules,
+                                  listVolumes,
+                                  listIsos,
+                                  listAccounts,
+                                  listSnapshotPolicies,
+                                  listDiskOfferings,
+                                  listVlanIpRanges,
+                                  listUsageRecords,
+                                  listNetworkServiceProviders,
+                                  listHosts,
+                                  listPublicIpAddresses,
+                                  listPortForwardingRules,
+                                  listLoadBalancerRules,
+                                  listSnapshots,
+                                  listUsers,
+                                  listEvents,
+                                  listServiceOfferings,
+                                  listVirtualRouterElements,
+                                  listNetworkOfferings,
+                                  listResourceLimits,
+                                  listVPCOfferings)
+from marvin.integration.lib.base import (Configurations,
+                                         NetScaler,
+                                         Template,
+                                         Resources,
+                                         PhysicalNetwork,
+                                         Host)
+from marvin.integration.lib.utils import (get_process_status,
+                                          xsplit)
+
 from marvin.sshClient import SshClient
-from utils import *
-from base import *
-from marvin.codes import PASS
+import random
 
 #Import System modules
 import time
@@ -91,7 +136,7 @@ def add_netscaler(apiclient, zoneid, NSservice):
       cmd = updateNetworkServiceProvider.updateNetworkServiceProviderCmd()
       cmd.id = netscaler_provider.id
       cmd.state =  'Enabled'
-      response = apiclient.updateNetworkServiceProvider(cmd)
+      apiclient.updateNetworkServiceProvider(cmd)
 
     return netscaler
 
@@ -199,19 +244,6 @@ def get_template(apiclient, zoneid, ostype, services=None):
                                                                     ostypeid)
     return
 
-def get_hypervisor_type(apiclient):
-
-    """Return the hypervisor type of the hosts in setup"""
-
-    hosts = list_hosts(apiclient, type='Routing', listall=True)
-
-    hosts_list_validation_result = validateList(hosts)
-
-    assert hosts_list_validation_result[0] == PASS, "host list validation failed"
-
-    return hosts_list_validation_result[1].hypervisor
-
-
 def download_systemplates_sec_storage(server, services):
     """Download System templates on sec storage"""
 
diff --git a/tools/marvin/marvin/integration/lib/utils.py b/tools/marvin/marvin/integration/lib/utils.py

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,9 @@`
`30`	`30`	`)`
`31`	`31`	`from marvin.integration.lib.common import (get_domain,`
`32`	`32`	`get_zone,`
`33`		`- get_template,`
`34`		`- cleanup_resources`
	`33`	`+ get_template`
`35`	`34`	`)`
	`35`	`+from marvin.integration.lib.utils import cleanup_resources`
`36`	`36`
`37`	`37`	`class Services:`
`38`	`38`	`"""Test resource limit services`
Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,9 @@`
`29`	`29`	`)`
`30`	`30`	`from marvin.integration.lib.common import (get_domain,`
`31`	`31`	`get_zone,`
`32`		`- get_template,`
`33`		`- cleanup_resources`
	`32`	`+ get_template`
`34`	`33`	`)`
	`34`	`+from marvin.integration.lib.utils import cleanup_resources`
`35`	`35`
`36`	`36`	`class Services:`
`37`	`37`	`"""Test memory resource limit services`