Skip to content

Commit 96d6a2a

Browse files
committed
CLOUDSTACK-6360: Fix JDK paths in ubuntu packaging init scripts, don't use 1.6
Since we've agreed to use JDK/JRE 1.7, this enforces that for Ubuntu builds - this fix remove usage of 1.6 paths in JDK_DIR for cloud-{agent, management, usage}. - adds oracle jdk 1.7 path (in case a user is using that) - adds mysql-connector-java path to CLASSPATH for usage server - adds libmysql-java pkg dependency (tested and available for precise and trusty) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
1 parent 72e06b4 commit 96d6a2a

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

debian/control

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Description: CloudStack agent
3131

3232
Package: cloudstack-usage
3333
Architecture: all
34-
Depends: openjdk-7-jre, cloudstack-common (= ${source:Version}), jsvc
34+
Depends: openjdk-7-jre, cloudstack-common (= ${source:Version}), jsvc, libmysql-java
3535
Description: CloudStack usage monitor
3636
The CloudStack usage monitor provides usage accounting across the entire cloud for
3737
cloud operators to charge based on usage parameters.

packaging/debian/init/cloud-agent

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ unset OPTIONS
4646
[ -r /etc/default/"$SHORTNAME" ] && source /etc/default/"$SHORTNAME"
4747

4848
# The first existing directory is used for JAVA_HOME (if JAVA_HOME is not defined in $DEFAULT)
49-
JDK_DIRS="/usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-6-openjdk /usr/lib/jvm/java-6-openjdk-i386 /usr/lib/jvm/java-6-openjdk-amd64 /usr/lib/jvm/java-6-sun"
49+
JDK_DIRS="/usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-7-oracle /usr/lib/jvm/java-6-openjdk /usr/lib/jvm/java-6-openjdk-i386 /usr/lib/jvm/java-6-openjdk-amd64 /usr/lib/jvm/java-6-sun"
5050

5151
for jdir in $JDK_DIRS; do
5252
if [ -r "$jdir/bin/java" -a -z "${JAVA_HOME}" ]; then

packaging/debian/init/cloud-management

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ TOMCAT6_USER=tomcat6
6565

6666
# The first existing directory is used for JAVA_HOME (if JAVA_HOME is not
6767
# defined in $DEFAULT)
68-
JDK_DIRS="/usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-6-openjdk /usr/lib/jvm/java-6-openjdk-i386 /usr/lib/jvm/java-6-openjdk-amd64 /usr/lib/jvm/java-6-sun"
68+
JDK_DIRS="/usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-7-oracle /usr/lib/jvm/java-7-openjdk /usr/lib/jvm/java-7-sun"
6969

7070
# Look for the right JVM to use
7171
for jdir in $JDK_DIRS; do

packaging/debian/init/cloud-usage

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ unset OPTIONS
4343
[ -r /etc/default/"$SHORTNAME" ] && source /etc/default/"$SHORTNAME"
4444

4545
# The first existing directory is used for JAVA_HOME (if JAVA_HOME is not defined in $DEFAULT)
46-
JDK_DIRS="/usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-6-openjdk /usr/lib/jvm/java-6-openjdk-i386 /usr/lib/jvm/java-6-openjdk-amd64 /usr/lib/jvm/java-6-sun"
46+
JDK_DIRS="/usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-7-oracle /usr/lib/jvm/java-7-openjdk /usr/lib/jvm/java-7-sun"
4747

4848
for jdir in $JDK_DIRS; do
4949
if [ -r "$jdir/bin/java" -a -z "${JAVA_HOME}" ]; then
@@ -57,7 +57,7 @@ PCP=`ls /usr/share/cloudstack-usage/plugins/*.jar 2>/dev/null | tr '\n' ':' | se
5757

5858
# We need to append the JSVC daemon JAR to the classpath
5959
# AgentShell implements the JSVC daemon methods
60-
export CLASSPATH="/usr/share/java/commons-daemon.jar:$UCP:$PCP:/etc/cloudstack/usage"
60+
export CLASSPATH="/usr/share/java/commons-daemon.jar:/usr/share/java/mysql-connector-java.jar:$UCP:$PCP:/etc/cloudstack/usage"
6161

6262
start() {
6363
if [ -s "$PIDFILE" ] && kill -0 $(cat "$PIDFILE") >/dev/null 2>&1; then

0 commit comments

Comments
 (0)