CLOUDSTACK-7700: Volume Snapshot Async Job returns Success for a failed

minchen07 · minchen07 · commit 1e20600ecaa3 · 2014-10-13T14:26:27.000-07:00
operation.
diff --git a/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java b/engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
@@ -1534,6 +1534,7 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume) {
             snapshot = snapshotMgr.takeSnapshot(volume);
         } catch (Exception e) {
             s_logger.debug("Take snapshot: " + volume.getId() + " failed", e);
+            throw new CloudRuntimeException("Failed to take snapshot", e);
         }
 
         return snapshot;

Original file line number	Diff line number	Diff line change
`@@ -1534,6 +1534,7 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume) {`
`1534`	`1534`	`snapshot = snapshotMgr.takeSnapshot(volume);`
`1535`	`1535`	`} catch (Exception e) {`
`1536`	`1536`	`s_logger.debug("Take snapshot: " + volume.getId() + " failed", e);`
	`1537`	`+ throw new CloudRuntimeException("Failed to take snapshot", e);`
`1537`	`1538`	`}`
`1538`	`1539`
`1539`	`1540`	`return snapshot;`