plugins/shutdown: fix triggerShutdown scheduling and response (#9276)

shwstppr · web-flow · commit 097359bef9ed · 2024-06-21T10:12:16.000+05:30
Earlier the triggerShutdown API would immediately shutdown the MS and if
it is the same MS on which API is called it would lead to error in the
API call. This change adds a delay to the process so the MS would be
able to send response to the API.

Signed-off-by: Abhishek Kumar &lt;abhishek.mrt22@gmail.com&gt;
diff --git a/plugins/shutdown/src/main/java/org/apache/cloudstack/shutdown/ShutdownManagerImpl.java b/plugins/shutdown/src/main/java/org/apache/cloudstack/shutdown/ShutdownManagerImpl.java
@@ -107,7 +107,10 @@ private void prepareForShutdown(boolean postTrigger) {
             this.shutdownTask = null;
         }
         this.shutdownTask = new ShutdownTask(this);
-        timer.scheduleAtFixedRate(shutdownTask, 0, 30L * 1000);
+        long period = 30L * 1000;
+        long delay = period / 2;
+        logger.debug(String.format("Scheduling shutdown task with delay: %d and period: %d", delay, period));
+        timer.scheduleAtFixedRate(shutdownTask, delay, period);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,10 @@ private void prepareForShutdown(boolean postTrigger) {`
`107`	`107`	`this.shutdownTask = null;`
`108`	`108`	`}`
`109`	`109`	`this.shutdownTask = new ShutdownTask(this);`
`110`		`- timer.scheduleAtFixedRate(shutdownTask, 0, 30L * 1000);`
	`110`	`+ long period = 30L * 1000;`
	`111`	`+ long delay = period / 2;`
	`112`	`+ logger.debug(String.format("Scheduling shutdown task with delay: %d and period: %d", delay, period));`
	`113`	`+ timer.scheduleAtFixedRate(shutdownTask, delay, period);`
`111`	`114`	`}`
`112`	`115`
`113`	`116`	`@Override`