Fix Spotbugs (#35313)

Abacn · web-flow · commit a9339063c94b · 2025-06-17T10:04:07.000-04:00
* Fix Spotbugs

* Fix checkstyle
diff --git a/.test-infra/mock-apis/build.gradle b/.test-infra/mock-apis/build.gradle
@@ -23,6 +23,7 @@
  applyJavaNature(
     exportJavadoc: false,
     publish: false,
+    enableSpotbugs: false
  )
 
 description = "Apache Beam :: Test Infra :: Mock APIs"
diff --git a/examples/java/src/main/java/org/apache/beam/examples/KafkaStreaming.java b/examples/java/src/main/java/org/apache/beam/examples/KafkaStreaming.java
@@ -172,16 +172,16 @@ public void run() {
     // A class that randomly selects a name with random amount of points
     static class RandomUserScoreGeneratorFn extends DoFn<Object, KV<String, Integer>> {
       private static final int MAX_SCORE = 100;
+      private static final Random RANDOM = new Random();
 
       @ProcessElement
       public void processElement(ProcessContext c) {
         c.output(generate());
       }
 
       public KV<String, Integer> generate() {
-        Random random = new Random();
-        String randomName = NAMES[random.nextInt(NAMES.length)];
-        int randomScore = random.nextInt(MAX_SCORE) + 1;
+        String randomName = NAMES[RANDOM.nextInt(NAMES.length)];
+        int randomScore = RANDOM.nextInt(MAX_SCORE) + 1;
         return KV.of(randomName, randomScore);
       }
     }
diff --git a/examples/java/src/main/java/org/apache/beam/examples/complete/TrafficRoutes.java b/examples/java/src/main/java/org/apache/beam/examples/complete/TrafficRoutes.java
@@ -405,8 +405,12 @@ public static void main(String[] args) throws IOException {
 
   private static Double tryParseAvgSpeed(String[] inputItems) {
     try {
-      return Double.parseDouble(tryParseString(inputItems, 9));
-    } catch (NumberFormatException | NullPointerException e) {
+      String parsed = tryParseString(inputItems, 9);
+      if (parsed == null) {
+        return null;
+      }
+      return Double.parseDouble(parsed);
+    } catch (NumberFormatException e) {
       return null;
     }
   }
diff --git a/examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/SchemasUtils.java b/examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/SchemasUtils.java
@@ -21,6 +21,7 @@
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
 
 import com.google.api.services.bigquery.model.TableSchema;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.Reader;
@@ -87,6 +88,7 @@ private void parseJson(String jsonSchema) throws UnsupportedOperationException {
     jsonBeamSchema = BigQueryHelpers.toJsonString(schema.getFields());
   }
 
+  @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION")
   private void validateSchemaTypes(TableSchema bigQuerySchema) {
     try {
       beamSchema = fromTableSchema(bigQuerySchema);
diff --git a/examples/java/src/main/java/org/apache/beam/examples/cookbook/TriggerExample.java b/examples/java/src/main/java/org/apache/beam/examples/cookbook/TriggerExample.java
@@ -501,11 +501,16 @@ public static class InsertDelays extends DoFn<String, String> {
     // MIN_DELAY and MAX_DELAY in minutes.
     private static final int MIN_DELAY = 1;
     private static final int MAX_DELAY = 100;
+    private transient Random random;
+
+    @Setup
+    public void setup() {
+      this.random = new Random();
+    }
 
     @ProcessElement
     public void processElement(ProcessContext c) throws Exception {
       Instant timestamp = Instant.now();
-      Random random = new Random();
       if (random.nextDouble() < THRESHOLD) {
         int range = MAX_DELAY - MIN_DELAY;
         int delayInMinutes = random.nextInt(range) + MIN_DELAY;
diff --git a/examples/java/src/main/java/org/apache/beam/examples/subprocess/configuration/SubProcessConfiguration.java b/examples/java/src/main/java/org/apache/beam/examples/subprocess/configuration/SubProcessConfiguration.java
@@ -17,13 +17,15 @@
  */
 package org.apache.beam.examples.subprocess.configuration;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.Serializable;
 
 /**
  * Configuration file used to setup the Process kernel for execution of the external library Values
  * are copied from the Options to all them to be Serializable.
  */
 @SuppressWarnings({"serial", "nullness"}) // TODO(https://github.com/apache/beam/issues/20497)
+@SuppressFBWarnings("PA_PUBLIC_PRIMITIVE_ATTRIBUTE") // TODO(#35312)
 public class SubProcessConfiguration implements Serializable {
 
   // Source GCS directory where the C++ library is located gs://bucket/tests
diff --git a/examples/kotlin/src/main/java/org/apache/beam/examples/kotlin/cookbook/TriggerExample.kt b/examples/kotlin/src/main/java/org/apache/beam/examples/kotlin/cookbook/TriggerExample.kt
@@ -486,6 +486,7 @@ object TriggerExample {
 
         @ProcessElement
         @Throws(Exception::class)
+        @SuppressFBWarnings("DMI_RANDOM_USED_ONLY_ONCE")
         fun processElement(c: ProcessContext) {
             var timestamp = Instant.now()
             val random = Random()
diff --git a/it/common/src/main/java/org/apache/beam/it/common/utils/ResourceManagerUtils.java b/it/common/src/main/java/org/apache/beam/it/common/utils/ResourceManagerUtils.java
@@ -97,10 +97,11 @@ public static String generateResourceId(
         + localDateTime.format(timeFormat);
   }
 
+  private static final Random RANDOM = new Random();
+
   /** Generates random letter for padding. */
   public static char generatePadding() {
-    Random random = new Random();
-    return (char) ('a' + random.nextInt(26));
+    return (char) ('a' + RANDOM.nextInt(26));
   }
 
   /**
@@ -205,18 +206,15 @@ public static String generatePassword(
         RandomStringUtils.randomAlphanumeric(minLength, maxLength - numSpecial).toUpperCase());
     for (int i = 0; i < numSpecial && specialChars != null; i++) {
       password.insert(
-          new Random().nextInt(password.length()),
-          specialChars.get(new Random().nextInt(specialChars.size())));
+          RANDOM.nextInt(password.length()), specialChars.get(RANDOM.nextInt(specialChars.size())));
     }
     for (int i = 0; i < numLower; i++) {
       password.insert(
-          new Random().nextInt(password.length()),
-          RandomStringUtils.randomAlphabetic(1).toLowerCase());
+          RANDOM.nextInt(password.length()), RandomStringUtils.randomAlphabetic(1).toLowerCase());
     }
     for (int i = 0; i < numUpper; i++) {
       password.insert(
-          new Random().nextInt(password.length()),
-          RandomStringUtils.randomAlphabetic(1).toUpperCase());
+          RANDOM.nextInt(password.length()), RandomStringUtils.randomAlphabetic(1).toUpperCase());
     }
     return password.toString();
   }
diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateSampler.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateSampler.java
@@ -19,6 +19,7 @@
 
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.Closeable;
 import java.util.Set;
 import java.util.concurrent.CancellationException;
@@ -51,6 +52,7 @@ protected ExecutionStateSampler(MillisProvider clock) {
     this.clock = clock;
   }
 
+  @SuppressFBWarnings("MS_EXPOSE_REP") // singleton
   public static ExecutionStateSampler instance() {
     return INSTANCE;
   }
diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FileReporter.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/FileReporter.java
@@ -65,6 +65,7 @@ public void open(MetricConfig config) {
   }
 
   @Override
+  @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION")
   public void notifyOfRemovedMetric(Metric metric, String metricName, MetricGroup group) {
     final String name = group.getMetricIdentifier(metricName, this);
     super.notifyOfRemovedMetric(metric, metricName, group);
diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPTransformMatchers.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPTransformMatchers.java
@@ -19,6 +19,7 @@
 
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.MoreObjects.toStringHelper;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.ArrayDeque;
 import org.apache.beam.sdk.Pipeline;
 import org.apache.beam.sdk.runners.AppliedPTransform;
@@ -69,6 +70,7 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
           && parentIsCombinePerKey(application);
     }
 
+    @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION") // TODO(#35312)
     private boolean parentIsCombinePerKey(AppliedPTransform<?, ?, ?> application) {
       // We want the PipelineVisitor below to change the parent, but the parent must be final to
       // be captured in there. To work around this issue, wrap the parent in a one element array.
diff --git a/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java b/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
@@ -1221,6 +1221,8 @@ private static boolean includesTransformUpgrades(Pipeline pipeline) {
         > 0);
   }
 
+  private static final Random RANDOM = new Random();
+
   @Override
   public DataflowPipelineJob run(Pipeline pipeline) {
     // Multi-language pipelines and pipelines that include upgrades should automatically be upgraded
@@ -1363,7 +1365,7 @@ public DataflowPipelineJob run(Pipeline pipeline) {
     // job previously created with the same job name, and that the job creation
     // has been effectively rejected. The SDK should return
     // Error::Already_Exists to user in that case.
-    int randomNum = new Random().nextInt(9000) + 1000;
+    int randomNum = RANDOM.nextInt(9000) + 1000;
     String requestId =
         DateTimeFormat.forPattern("YYYYMMddHHmmssmmm")
                 .withZone(DateTimeZone.UTC)
diff --git a/runners/samza/src/main/java/org/apache/beam/runners/samza/container/ContainerCfgLoader.java b/runners/samza/src/main/java/org/apache/beam/runners/samza/container/ContainerCfgLoader.java
@@ -38,6 +38,7 @@ public class ContainerCfgLoader implements ConfigLoader {
 
   private static final Object LOCK = new Object();
   static volatile JobModel jobModel;
+  private static final Random RANDOM = new Random();
 
   @Override
   public Config getConfig() {
@@ -48,8 +49,7 @@ public Config getConfig() {
           LOG.info(String.format("Got container ID: %s", containerId));
           final String coordinatorUrl = System.getenv(ShellCommandConfig.ENV_COORDINATOR_URL);
           LOG.info(String.format("Got coordinator URL: %s", coordinatorUrl));
-          final int delay =
-              new Random().nextInt(SamzaContainer.DEFAULT_READ_JOBMODEL_DELAY_MS()) + 1;
+          final int delay = RANDOM.nextInt(SamzaContainer.DEFAULT_READ_JOBMODEL_DELAY_MS()) + 1;
           jobModel = SamzaContainer.readJobModel(coordinatorUrl, delay);
         }
       }
diff --git a/sdks/java/build-tools/src/main/resources/beam/spotbugs-filter.xml b/sdks/java/build-tools/src/main/resources/beam/spotbugs-filter.xml
@@ -55,6 +55,10 @@
   -->
   <Bug pattern="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS"/>
 
+  <!-- TODO(https://github.com/apache/beam/issues/35312) resolve findings-->
+  <Bug pattern="CT_CONSTRUCTOR_THROW"/>
+  <Bug pattern="MS_EXPOSE_REP"/>
+
   <!--
     Many test classes are captured by lambdas and marked `implements Serializable`. They are not
     actually serializable, so the TestPipeline that they employ does not need to be transient or
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderProviders.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/CoderProviders.java
@@ -19,6 +19,7 @@
 
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.lang.reflect.Modifier;
@@ -56,6 +57,7 @@ public static CoderProvider forCoder(TypeDescriptor<?> type, Coder<?> coder) {
    */
   private static class CoderProviderFromStaticMethods extends CoderProvider {
 
+    @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION") // TODO(#35312)
     @Override
     public <T> Coder<T> coderFor(TypeDescriptor<T> type, List<? extends Coder<?>> componentCoders)
         throws CannotProvideCoderException {
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/DefaultCoder.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/DefaultCoder.java
@@ -17,6 +17,7 @@
  */
 package org.apache.beam.sdk.coders;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.lang.annotation.Documented;
 import java.lang.annotation.ElementType;
 import java.lang.annotation.Retention;
@@ -81,6 +82,7 @@ public static class DefaultCoderProvider extends CoderProvider {
        * Returns the {@link Coder} returned according to the {@link CoderProvider} from any {@link
        * DefaultCoder} annotation on the given class.
        */
+      @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION") // TODO(#35312)
       @Override
       public <T> Coder<T> coderFor(
           TypeDescriptor<T> typeDescriptor, List<? extends Coder<?>> componentCoders)
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/resourcehints/ResourceHints.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/resourcehints/ResourceHints.java
@@ -174,7 +174,7 @@ public static long parse(String s) {
         String number = m.group(1);
         String suffix = m.group(2);
         if (number != null && suffix != null && suffixes.containsKey(suffix)) {
-          return (long) (Double.valueOf(number) * suffixes.get(suffix));
+          return (long) (Double.parseDouble(number) * suffixes.get(suffix));
         }
       }
       throw new IllegalArgumentException("Unable to parse '" + s + "' as a byte value.");
diff --git a/sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/AnnotateImages.java b/sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/AnnotateImages.java
@@ -126,12 +126,13 @@ public PCollection<List<AnnotateImageResponse>> expand(PCollection<T> input) {
     } else {
       inputToRequestMapper = ParDo.of(new MapInputToRequest(null));
     }
+    Random random = new Random();
     return input
         .apply(inputToRequestMapper)
         .apply(
             WithKeys.of(
                     (SerializableFunction<AnnotateImageRequest, Integer>)
-                        ignored -> new Random().nextInt(desiredRequestParallelism))
+                        ignored -> random.nextInt(desiredRequestParallelism))
                 .withKeyType(TypeDescriptors.integers()))
         .apply(GroupIntoBatches.ofSize(batchSize))
         .apply(ParDo.of(new PerformImageAnnotation()));
diff --git a/sdks/java/io/debezium/build.gradle b/sdks/java/io/debezium/build.gradle
@@ -23,7 +23,6 @@ applyJavaNature(
         mavenRepositories: [
                 [id: 'io.confluent', url: 'https://packages.confluent.io/maven/']
         ],
-        enableSpotbugs: false,
         requireJavaVersion: JavaVersion.VERSION_17,
 )
 provideIntegrationTestingDependencies()
diff --git a/sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/KafkaSourceConsumerFn.java b/sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/KafkaSourceConsumerFn.java
@@ -19,6 +19,7 @@
 
 import static org.apache.beam.io.debezium.KafkaConnectUtils.debeziumRecordInstant;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.debezium.document.Document;
 import io.debezium.document.DocumentReader;
 import io.debezium.document.DocumentWriter;
@@ -131,6 +132,7 @@ public class KafkaSourceConsumerFn<T> extends DoFn<Map<String, String>, T> {
     this(connectorClass, fn, maxRecords, null);
   }
 
+  @SuppressFBWarnings("ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD")
   @GetInitialRestriction
   public OffsetHolder getInitialRestriction(@Element Map<String, String> unused)
       throws IOException {
diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
@@ -2477,7 +2477,7 @@ public void setParameters(T element, PreparedStatement preparedStatement) throws
                     preparedStatementFieldSetterList
                         .get(index)
                         .set(row, preparedStatement, index, fields.get(index));
-                  } catch (SQLException | NullPointerException e) {
+                  } catch (SQLException e) {
                     throw new RuntimeException("Error while setting data to preparedStatement", e);
                   }
                 });
diff --git a/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java b/sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java
@@ -21,6 +21,7 @@
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
 
 import com.google.auto.value.AutoValue;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serializable;
 import java.nio.charset.StandardCharsets;
@@ -1230,6 +1231,7 @@ void connect() throws JMSException {
         }
       }
 
+      @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION") // TODO(#35312)
       void publishMessage(T input) throws JMSException, JmsIOException {
         Destination destinationToSendTo = destination;
         try {
diff --git a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaExactlyOnceSink.java
@@ -23,6 +23,7 @@
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.util.HashMap;
 import java.util.Iterator;
@@ -550,6 +551,7 @@ void commitTxn(long lastRecordId, Counter numTransactions) throws IOException {
       }
     }
 
+    @SuppressFBWarnings("DMI_RANDOM_USED_ONLY_ONCE") // TODO(#35312)
     private ShardWriter<K, V> initShardWriter(
         int shard, ValueState<String> writerIdState, long nextId) throws IOException {
 
diff --git a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIOUtils.java b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIOUtils.java
@@ -20,6 +20,7 @@
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkState;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
 import java.util.Map;
@@ -98,6 +99,7 @@ static Map<String, Object> updateKafkaProperties(
     return config;
   }
 
+  @SuppressFBWarnings("DMI_RANDOM_USED_ONLY_ONCE") // TODO(#35312)
   static Map<String, Object> getOffsetConsumerConfig(
       String name, @Nullable Map<String, Object> offsetConfig, Map<String, Object> consumerConfig) {
     Map<String, Object> offsetConsumerConfig = new HashMap<>(consumerConfig);
diff --git a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java
@@ -408,7 +408,7 @@ public boolean offsetBasedDeduplicationSupported() {
   /** watermark before any records have been read. */
   private static Instant initialWatermark = BoundedWindow.TIMESTAMP_MIN_VALUE;
 
-  public KafkaMetrics kafkaResults = KafkaSinkMetrics.kafkaMetrics();
+  private KafkaMetrics kafkaResults = KafkaSinkMetrics.kafkaMetrics();
   private Stopwatch stopwatch = Stopwatch.createUnstarted();
 
   private Set<String> kafkaTopics;
diff --git a/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/KeyPairUtils.java b/sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/KeyPairUtils.java
@@ -17,6 +17,7 @@
  */
 package org.apache.beam.sdk.io.snowflake;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.StringReader;
 import java.nio.charset.StandardCharsets;
@@ -47,6 +48,7 @@ private enum KeyEncryptionState {
     UNKNOWN
   }
 
+  @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION")
   public static PrivateKey preparePrivateKey(String privateKey, String privateKeyPassphrase) {
     try {
       KeyFactory keyFactory = KeyFactory.getInstance("RSA");
diff --git a/sdks/java/io/synthetic/src/main/java/org/apache/beam/sdk/io/synthetic/SyntheticOptions.java b/sdks/java/io/synthetic/src/main/java/org/apache/beam/sdk/io/synthetic/SyntheticOptions.java
diff --git a/sdks/java/io/synthetic/src/main/java/org/apache/beam/sdk/io/synthetic/SyntheticStep.java b/sdks/java/io/synthetic/src/main/java/org/apache/beam/sdk/io/synthetic/SyntheticStep.java
diff --git a/sdks/java/testing/jpms-tests/build.gradle b/sdks/java/testing/jpms-tests/build.gradle
diff --git a/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkConfiguration.java b/sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkConfiguration.java

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`	`applyJavaNature(`
`24`	`24`	`exportJavadoc: false,`
`25`	`25`	`publish: false,`
	`26`	`+ enableSpotbugs: false`
`26`	`27`	`)`
`27`	`28`
`28`	`29`	`description = "Apache Beam :: Test Infra :: Mock APIs"`
Original file line number	Diff line number	Diff line change
`@@ -172,16 +172,16 @@ public void run() {`
`172`	`172`	`// A class that randomly selects a name with random amount of points`
`173`	`173`	`static class RandomUserScoreGeneratorFn extends DoFn<Object, KV<String, Integer>> {`
`174`	`174`	`private static final int MAX_SCORE = 100;`
	`175`	`+ private static final Random RANDOM = new Random();`
`175`	`176`
`176`	`177`	`@ProcessElement`
`177`	`178`	`public void processElement(ProcessContext c) {`
`178`	`179`	`c.output(generate());`
`179`	`180`	`}`
`180`	`181`
`181`	`182`	`public KV<String, Integer> generate() {`
`182`		`- Random random = new Random();`
`183`		`- String randomName = NAMES[random.nextInt(NAMES.length)];`
`184`		`- int randomScore = random.nextInt(MAX_SCORE) + 1;`
	`183`	`+ String randomName = NAMES[RANDOM.nextInt(NAMES.length)];`
	`184`	`+ int randomScore = RANDOM.nextInt(MAX_SCORE) + 1;`
`185`	`185`	`return KV.of(randomName, randomScore);`
`186`	`186`	`}`
`187`	`187`	`}`
Original file line number	Diff line number	Diff line change
`@@ -405,8 +405,12 @@ public static void main(String[] args) throws IOException {`
`405`	`405`
`406`	`406`	`private static Double tryParseAvgSpeed(String[] inputItems) {`
`407`	`407`	`try {`
`408`		`- return Double.parseDouble(tryParseString(inputItems, 9));`
`409`		`- } catch (NumberFormatException \| NullPointerException e) {`
	`408`	`+ String parsed = tryParseString(inputItems, 9);`
	`409`	`+ if (parsed == null) {`
	`410`	`+ return null;`
	`411`	`+ }`
	`412`	`+ return Double.parseDouble(parsed);`
	`413`	`+ } catch (NumberFormatException e) {`
`410`	`414`	`return null;`
`411`	`415`	`}`
`412`	`416`	`}`
Original file line number	Diff line number	Diff line change
`@@ -97,10 +97,11 @@ public static String generateResourceId(`
`97`	`97`	`+ localDateTime.format(timeFormat);`
`98`	`98`	`}`
`99`	`99`
	`100`	`+ private static final Random RANDOM = new Random();`
	`101`	`+`
`100`	`102`	`/** Generates random letter for padding. */`
`101`	`103`	`public static char generatePadding() {`
`102`		`- Random random = new Random();`
`103`		`- return (char) ('a' + random.nextInt(26));`
	`104`	`+ return (char) ('a' + RANDOM.nextInt(26));`
`104`	`105`	`}`
`105`	`106`
`106`	`107`	`/**`
`@@ -205,18 +206,15 @@ public static String generatePassword(`
`205`	`206`	`RandomStringUtils.randomAlphanumeric(minLength, maxLength - numSpecial).toUpperCase());`
`206`	`207`	`for (int i = 0; i < numSpecial && specialChars != null; i++) {`
`207`	`208`	`password.insert(`
`208`		`- new Random().nextInt(password.length()),`
`209`		`- specialChars.get(new Random().nextInt(specialChars.size())));`
	`209`	`+ RANDOM.nextInt(password.length()), specialChars.get(RANDOM.nextInt(specialChars.size())));`
`210`	`210`	`}`
`211`	`211`	`for (int i = 0; i < numLower; i++) {`
`212`	`212`	`password.insert(`
`213`		`- new Random().nextInt(password.length()),`
`214`		`- RandomStringUtils.randomAlphabetic(1).toLowerCase());`
	`213`	`+ RANDOM.nextInt(password.length()), RandomStringUtils.randomAlphabetic(1).toLowerCase());`
`215`	`214`	`}`
`216`	`215`	`for (int i = 0; i < numUpper; i++) {`
`217`	`216`	`password.insert(`
`218`		`- new Random().nextInt(password.length()),`
`219`		`- RandomStringUtils.randomAlphabetic(1).toUpperCase());`
	`217`	`+ RANDOM.nextInt(password.length()), RandomStringUtils.randomAlphabetic(1).toUpperCase());`
`220`	`218`	`}`
`221`	`219`	`return password.toString();`
`222`	`220`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`
`20`	`20`	`import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull;`
`21`	`21`
	`22`	`+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;`
`22`	`23`	`import java.io.Closeable;`
`23`	`24`	`import java.util.Set;`
`24`	`25`	`import java.util.concurrent.CancellationException;`
`@@ -51,6 +52,7 @@ protected ExecutionStateSampler(MillisProvider clock) {`
`51`	`52`	`this.clock = clock;`
`52`	`53`	`}`
`53`	`54`
	`55`	`+ @SuppressFBWarnings("MS_EXPOSE_REP") // singleton`
`54`	`56`	`public static ExecutionStateSampler instance() {`
`55`	`57`	`return INSTANCE;`
`56`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ public void open(MetricConfig config) {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`@Override`
	`68`	`+ @SuppressFBWarnings("DCN_NULLPOINTER_EXCEPTION")`
`68`	`69`	`public void notifyOfRemovedMetric(Metric metric, String metricName, MetricGroup group) {`
`69`	`70`	`final String name = group.getMetricIdentifier(metricName, this);`
`70`	`71`	`super.notifyOfRemovedMetric(metric, metricName, group);`