GH-49156: [Python] Require GIL for string comparison (#49161)

raulcd · web-flow · commit 0dfae701ef98 · 2026-02-06T12:27:31.000+01:00
### Rationale for this change With Cython 3.3.0.a0 this failed. After some discussion it seems that this should have always had to require the GIL. ### What changes are included in this PR? Moving statement out of the `with nogil` context manager. ### Are these changes tested? Existing CI builds pyarrow. ### Are there any user-facing changes? No * GitHub Issue: #49156 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
diff --git a/python/pyarrow/table.pxi b/python/pyarrow/table.pxi
@@ -6286,8 +6286,8 @@ def concat_tables(tables, MemoryPool memory_pool=None, str promote_options="none
         "default" if promote_options == "none" else promote_options
     )
 
+    options.unify_schemas = promote_options != "none"
     with nogil:
-        options.unify_schemas = promote_options != "none"
         c_result_table = GetResultValue(
             ConcatenateTables(c_tables, options, pool))
 

Original file line number	Diff line number	Diff line change
`@@ -6286,8 +6286,8 @@ def concat_tables(tables, MemoryPool memory_pool=None, str promote_options="none`
`6286`	`6286`	`"default" if promote_options == "none" else promote_options`
`6287`	`6287`	`)`
`6288`	`6288`
	`6289`	`+ options.unify_schemas = promote_options != "none"`
`6289`	`6290`	`with nogil:`
`6290`		`- options.unify_schemas = promote_options != "none"`
`6291`	`6291`	`c_result_table = GetResultValue(`
`6292`	`6292`	`ConcatenateTables(c_tables, options, pool))`
`6293`	`6293`