Repository navigation
Expand file tree
/
Copy pathtest_infra_diff.py
More file actions
181 lines (155 loc) · 6.55 KB
/
Copy pathtest_infra_diff.py
File metadata and controls
181 lines (155 loc) · 6.55 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
from unittest.mock import patch
import pytest
from google.protobuf import wrappers_pb2 as wrappers
from feast.diff.infra_diff import (
diff_between,
diff_infra_protos,
tag_infra_proto_objects_for_keep_delete_add,
)
from feast.diff.property_diff import TransitionType
from feast.infra.online_stores.datastore import DatastoreTable
from feast.infra.online_stores.sqlite import SqliteTable
from feast.protos.feast.core.InfraObject_pb2 import Infra as InfraProto
@pytest.fixture
def datastore_table():
def build(name="table"):
return DatastoreTable(
project="test", name=name, project_id="pre", namespace="pre", database="pre"
)
return build
def test_tag_infra_proto_objects_for_keep_delete_add(datastore_table):
to_delete = datastore_table(name="to_delete").to_proto()
to_add = datastore_table(name="to_add").to_proto()
unchanged_table = datastore_table(name="unchanged").to_proto()
pre_changed = datastore_table(name="table").to_proto()
post_changed = datastore_table(name="table").to_proto()
keep, delete, add = tag_infra_proto_objects_for_keep_delete_add(
[to_delete, unchanged_table, pre_changed],
[to_add, unchanged_table, post_changed],
)
assert len(list(keep)) == 2
assert unchanged_table in keep
assert post_changed in keep
assert to_add not in keep
assert len(list(delete)) == 1
assert to_delete in delete
assert unchanged_table not in delete
assert pre_changed not in delete
assert len(list(add)) == 1
assert to_add in add
assert unchanged_table not in add
assert post_changed not in add
def test_diff_between_datastore_tables(datastore_table):
pre_changed = datastore_table().to_proto()
post_changed = DatastoreTable(
project="test",
name="table",
project_id="post",
namespace="post",
database="post",
).to_proto()
infra_object_diff = diff_between(pre_changed, pre_changed, "datastore table")
infra_object_property_diffs = infra_object_diff.infra_object_property_diffs
assert len(infra_object_property_diffs) == 0
infra_object_diff = diff_between(pre_changed, post_changed, "datastore table")
infra_object_property_diffs = infra_object_diff.infra_object_property_diffs
assert len(infra_object_property_diffs) == 3
assert infra_object_property_diffs[0].property_name == "project_id"
assert infra_object_property_diffs[0].val_existing == wrappers.StringValue(
value="pre"
)
assert infra_object_property_diffs[0].val_declared == wrappers.StringValue(
value="post"
)
assert infra_object_property_diffs[1].property_name == "namespace"
assert infra_object_property_diffs[1].val_existing == wrappers.StringValue(
value="pre"
)
assert infra_object_property_diffs[1].val_declared == wrappers.StringValue(
value="post"
)
assert infra_object_property_diffs[2].property_name == "database"
assert infra_object_property_diffs[2].val_existing == wrappers.StringValue(
value="pre"
)
assert infra_object_property_diffs[2].val_declared == wrappers.StringValue(
value="post"
)
@patch("feast.infra.online_stores.sqlite._initialize_conn")
def test_diff_infra_protos(_, tmp_path):
db_dir = tmp_path / "db"
db_dir.mkdir()
db_dir_str = str(db_dir)
to_delete = SqliteTable(path=db_dir_str, name="to_delete")
to_add = SqliteTable(path=db_dir_str, name="to_add")
unchanged_table = SqliteTable(path=db_dir_str, name="unchanged")
pre_changed = DatastoreTable(
project="test", name="table", project_id="pre", namespace="pre"
)
post_changed = DatastoreTable(
project="test", name="table", project_id="post", namespace="post"
)
infra_objects_before = [to_delete, unchanged_table, pre_changed]
infra_objects_after = [to_add, unchanged_table, post_changed]
infra_proto_before = InfraProto()
infra_proto_before.infra_objects.extend(
[obj.to_infra_object_proto() for obj in infra_objects_before]
)
infra_proto_after = InfraProto()
infra_proto_after.infra_objects.extend(
[obj.to_infra_object_proto() for obj in infra_objects_after]
)
infra_diff = diff_infra_protos(infra_proto_before, infra_proto_after)
infra_object_diffs = infra_diff.infra_object_diffs
# There should be one addition, one deletion, one unchanged, and one changed.
assert len(infra_object_diffs) == 4
additions = [
infra_object_diff
for infra_object_diff in infra_object_diffs
if infra_object_diff.transition_type == TransitionType.CREATE
]
assert len(additions) == 1
assert not additions[0].current_infra_object
assert additions[0].new_infra_object == to_add.to_proto()
assert len(additions[0].infra_object_property_diffs) == 0
deletions = [
infra_object_diff
for infra_object_diff in infra_object_diffs
if infra_object_diff.transition_type == TransitionType.DELETE
]
assert len(deletions) == 1
assert deletions[0].current_infra_object == to_delete.to_proto()
assert not deletions[0].new_infra_object
assert len(deletions[0].infra_object_property_diffs) == 0
unchanged = [
infra_object_diff
for infra_object_diff in infra_object_diffs
if infra_object_diff.transition_type == TransitionType.UNCHANGED
]
assert len(unchanged) == 1
assert unchanged[0].current_infra_object == unchanged_table.to_proto()
assert unchanged[0].new_infra_object == unchanged_table.to_proto()
assert len(unchanged[0].infra_object_property_diffs) == 0
updates = [
infra_object_diff
for infra_object_diff in infra_object_diffs
if infra_object_diff.transition_type == TransitionType.UPDATE
]
assert len(updates) == 1
assert updates[0].current_infra_object == pre_changed.to_proto()
assert updates[0].new_infra_object == post_changed.to_proto()
assert len(updates[0].infra_object_property_diffs) == 2
assert updates[0].infra_object_property_diffs[0].property_name == "project_id"
assert updates[0].infra_object_property_diffs[
0
].val_existing == wrappers.StringValue(value="pre")
assert updates[0].infra_object_property_diffs[
0
].val_declared == wrappers.StringValue(value="post")
assert updates[0].infra_object_property_diffs[1].property_name == "namespace"
assert updates[0].infra_object_property_diffs[
1
].val_existing == wrappers.StringValue(value="pre")
assert updates[0].infra_object_property_diffs[
1
].val_declared == wrappers.StringValue(value="post")