windows fixes#374
Merged
Merged
Conversation
Member
thdxr
commented
Jun 24, 2025
- fix(scripts): add Git hook for Windows
- fix: don't allow ':' in log file and project dir
- fix: parse file:// URLs correctly on Windows
- fix(tui): don't use path/filepath for embed
Create an equivalent of scripts/hooks for non-WSL Windows. This fixes errors in 'bun install'.
Windows does not allow ':' in file or directory names. Make sure the log file and the project directory do not contain ':' to prevent ENOENT errors.
On Windows, URL.pathname returns a path with an extra leading '/' (e.g. '\C:\Users\whatever'). This causes problems when using Bun.spawn(). Fix these problems by using the right method instead of URL.pathname.
EmbedFS uses '/' always for file paths. It does not support '\' even on Windows. Make sure we don't give EmbedFS a '\' path on Windows. This lets the TUI find the theme files, avoiding crashes in various parts of the code that assume a theme exists.
moutansos
pushed a commit
to moutansos/opencode
that referenced
this pull request
Jun 25, 2025
Co-authored-by: Matthew Glazar <strager.nds@gmail.com>
achembarpu
pushed a commit
to achembarpu/opencode
that referenced
this pull request
Aug 4, 2025
Co-authored-by: Matthew Glazar <strager.nds@gmail.com>
xywsxp
pushed a commit
to xywsxp/opencode
that referenced
this pull request
Apr 24, 2026
Co-authored-by: Matthew Glazar <strager.nds@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.