fix(opencode): dedupe event openapi refs#28892
Draft
sainzs wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28826
Type of change
What does this PR do?
The OpenAPI generator was adding some event payload schemas through both the bus event list and the core EventV2 list. This dedupes those schema refs before writing the
EventandGlobalEvent.payloadunions, so generated OpenAPI output no longer lists the sameEventSessionNext*schemas twice.The regression test checks both affected OpenAPI unions for duplicate refs.
How did you verify your code works?
bun test test/server/httpapi-public-openapi.test.ts: passbun typecheckfrompackages/opencode: passbun turbo typecheck: passScreenshots / recordings
N/A, API schema output only.
Checklist
AI-assisted; human-reviewed, locally tested, and I can explain/iterate on the change.