Simplify bg task session waking

tomjw64 · tomjw64 · commit 7f3d66493e41 · 2026-03-02T08:50:17.000-06:00
diff --git a/packages/opencode/src/session/background.ts b/packages/opencode/src/session/background.ts
@@ -11,14 +11,16 @@ export namespace SessionBackground {
 
   const state = Instance.state(
     () => {
-      const finished = new Map<string, Session.BackgroundTask[]>()
+      const wakeable = new Set<string>()
       const unsubscribes = [
         Bus.subscribe(Session.Event.BackgroundTaskCompleted, async (event) => {
           const sessionID = event.properties.sessionID
           const task = event.properties.task
 
-          await addFinishedTask(sessionID, task).catch((err) => {
-            log.error("failed to stage background task", { sessionID, error: err })
+          await updateTaskMessage(sessionID, task).then(() => {
+            state().wakeable.add(sessionID)
+          }).catch((err) => {
+            log.error("failed to update background task session message", { sessionID, error: err })
           })
           await wake(sessionID).catch((err) => {
             log.error("failed to wake for finished tasks", { sessionID, error: err })
@@ -32,7 +34,7 @@ export namespace SessionBackground {
           })
         }),
       ]
-      return { finished, unsubscribes }
+      return { wakeable, unsubscribes }
     },
     async (current) => {
       for (const unsubscribe of current.unsubscribes) {
@@ -55,8 +57,7 @@ export namespace SessionBackground {
     }
 
     const s = state()
-    const tasks = s.finished.get(sessionID)
-    if (!tasks || tasks.length === 0) {
+    if (!s.wakeable.has(sessionID)) {
       return
     }
 
@@ -65,20 +66,11 @@ export namespace SessionBackground {
       return
     }
 
-    s.finished.delete(sessionID)
+    s.wakeable.delete(sessionID)
     SessionStatus.set(sessionID, { type: "busy" })
     await SessionPrompt.loop({ sessionID })
   }
 
-  async function addFinishedTask(sessionID: string, task: Session.BackgroundTask) {
-    await updateTaskMessage(sessionID, task)
-
-    const finished = state().finished
-    const tasks = finished.get(sessionID) ?? []
-    finished.set(sessionID, tasks)
-    tasks.push(task)
-  }
-
   async function updateTaskMessage(sessionID: string, task: Session.BackgroundTask) {
     const msgID = Identifier.ascending("message")
     const output = [`Session ID: ${task.sessionID}`, "", "<task_result>", task.result, "</task_result>"].join("\n")
