fix(RootScope): set the scope on ScopeAware root context

vicb · rkirov · commit 99a2d372b53a · 2014-12-15T16:40:24.000-08:00
fixes dart-archive#1554
diff --git a/lib/core/scope.dart b/lib/core/scope.dart
@@ -773,6 +773,7 @@ class RootScope extends Scope {
     _zone.onError = (e, s, ls) => _exceptionHandler(e, s);
     _zone.onScheduleMicrotask = runAsync;
     cacheRegister.registerCache("ScopeWatchASTs", astCache);
+    if (context is ScopeAware) context.scope = this;
   }
 
   RootScope get rootScope => this;
diff --git a/test/core/scope_spec.dart b/test/core/scope_spec.dart
@@ -24,6 +24,18 @@ void main() {
           ..bind(ScopeStatsEmitter, toImplementation: MockScopeStatsEmitter);
     });
 
+    describe('Root context', () {
+      beforeEachModule((Module module) {
+        module.bind(Object, toImplementation: _RootContext);
+      });
+
+      it('should set the scope when RootContext is ScopeAware',
+          (RootScope rootScope, Object rootContext) {
+        expect(rootContext).toBeAnInstanceOf(_RootContext);
+        expect((rootContext as _RootContext).scope).toBe(rootScope);
+      });
+    });
+
     describe('AST Bridge', () {
       it('should watch field', (Logger logger, Map context, RootScope rootScope) {
         context['field'] = 'Worked!';
@@ -1751,3 +1763,7 @@ class UnstableList {
 class Foo {
   increment(x) => x+1;
 }
+
+class _RootContext implements ScopeAware {
+  var scope;
+}

Original file line number	Diff line number	Diff line change
`@@ -773,6 +773,7 @@ class RootScope extends Scope {`
`773`	`773`	`_zone.onError = (e, s, ls) => _exceptionHandler(e, s);`
`774`	`774`	`_zone.onScheduleMicrotask = runAsync;`
`775`	`775`	`cacheRegister.registerCache("ScopeWatchASTs", astCache);`
	`776`	`+ if (context is ScopeAware) context.scope = this;`
`776`	`777`	`}`
`777`	`778`
`778`	`779`	`RootScope get rootScope => this;`