Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.
This repository was archived by the owner on May 29, 2019. It is now read-only.

'string' type resolves in $modals are not supported #2676

Closed
Closed
'string' type resolves in $modals are not supported#2676
Labels
component: modaltype: enhancement
Milestone
0.13.3 (Fixes)

Description

@simoneb
simoneb
opened on Sep 9, 2014

As per https://github.com/angular-ui/bootstrap/blob/master/src/modal/modal.js#L322 it seems that 'string' type resolves are not handled properly in $modal.

Activity

  1. chrisirhc
    added
    type: enhancement
    component: modal
    on Oct 6, 2014
  2. wesleycho
    added a commit that references this issue on Aug 6, 2015

    feat(modal): allow users to resolve with strings

    30aa6e5
  3. wesleycho
    added this to the 0.13.3 (Fixes) milestone on Aug 6, 2015
  4. wesleycho
    closed this as completedin 8936885on Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component: modaltype: enhancement

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions