Skip to content

Commit 6082c1f

Browse files
crisbetocrisbeto
authored
build: remove slack notification config (#31228)
The job that notifies Slack when a build failed has been broken for a while, likely due to a dependency update and the channel where the updates were being posted only had a handful of team members. These changes remove it since it adds some noise when other failures happen and we're generally good at keeping the CI green.
1 parent 7fbc4d4 commit 6082c1f

5 files changed

Lines changed: 1 addition & 122 deletions

File tree

‎.github/actions/slack/action.yml‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,6 @@ jobs:
4444
run: pnpm tslint
4545
- name: Check for circular dependencies
4646
run: pnpm -s ts-circular-deps:check
47-
- uses: ./.github/actions/slack
48-
if: failure()
49-
with:
50-
JOB_NAME: 'Lint check'
51-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
5247

5348
api_golden_checks:
5449
runs-on: ubuntu-latest
@@ -67,11 +62,6 @@ jobs:
6762
run: pnpm install --frozen-lockfile
6863
- name: Check API Goldens
6964
run: pnpm bazel test goldens/...
70-
- uses: ./.github/actions/slack
71-
if: failure()
72-
with:
73-
JOB_NAME: 'API Golden Checks'
74-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
7565

7666
e2e:
7767
runs-on: ubuntu-latest
@@ -90,11 +80,6 @@ jobs:
9080
run: pnpm install --frozen-lockfile
9181
- name: Run e2e tests
9282
run: pnpm e2e --flaky_test_attempts=2
93-
- uses: ./.github/actions/slack
94-
if: failure()
95-
with:
96-
JOB_NAME: 'E2E test'
97-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
9883

9984
integration:
10085
runs-on: ubuntu-latest
@@ -114,11 +99,6 @@ jobs:
11499
- name: Run integration tests
115100
run: pnpm integration-tests
116101
continue-on-error: true
117-
- uses: ./.github/actions/slack
118-
if: failure()
119-
with:
120-
JOB_NAME: 'Integration test'
121-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
122102

123103
test:
124104
runs-on: ubuntu-latest-16core
@@ -137,11 +117,6 @@ jobs:
137117
run: pnpm install --frozen-lockfile
138118
- name: Run tests
139119
run: bazel test --build_tag_filters=-e2e --test_tag_filters=-e2e --build_tests_only -- src/...
140-
- uses: ./.github/actions/slack
141-
if: failure()
142-
with:
143-
JOB_NAME: 'Test'
144-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
145120

146121
build:
147122
runs-on: ubuntu-latest-16core
@@ -160,11 +135,6 @@ jobs:
160135
run: pnpm install --frozen-lockfile
161136
- name: Run tests
162137
run: bazel build --build_tag_filters=-docs-package,-release-package -- src/...
163-
- uses: ./.github/actions/slack
164-
if: failure()
165-
with:
166-
JOB_NAME: 'Build'
167-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
168138

169139
publish_snapshots:
170140
runs-on: ubuntu-latest-4core
@@ -191,11 +161,6 @@ jobs:
191161
run: ./scripts/circleci/publish-snapshots.sh
192162
env:
193163
SNAPSHOT_BUILDS_GITHUB_TOKEN: ${{ secrets.SNAPSHOT_BUILDS_GITHUB_TOKEN }}
194-
- uses: ./.github/actions/slack
195-
if: failure()
196-
with:
197-
JOB_NAME: 'Snapshot publishing'
198-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
199164

200165
deploy_doc_site:
201166
runs-on: ubuntu-latest-4core
@@ -225,11 +190,6 @@ jobs:
225190
CIRCLE_SHA1: ${{ github.sha }}
226191
DOCS_SITE_GCP_SERVICE_KEY: ${{ secrets.DOCS_SITE_GCP_SERVICE_KEY }}
227192
DOCS_DEPLOY_GITHUB_TOKEN: ${{ secrets.DOCS_DEPLOY_GITHUB_TOKEN }}
228-
- uses: ./.github/actions/slack
229-
if: failure()
230-
with:
231-
JOB_NAME: 'Docs site deployment'
232-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
233193

234194
browserstack:
235195
runs-on: ubuntu-latest

‎.github/workflows/scheduled-ci.yml‎

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ jobs:
3636
run: pnpm install
3737
- name: Run Browser tests
3838
run: pnpm bazel test --build_tag_filters=-e2e --test_tag_filters=-e2e --build_tests_only -- src/...
39-
- uses: ./.github/actions/slack
40-
if: ${{ failure() && github.event_name == 'push' }}
41-
with:
42-
JOB_NAME: 'Browser snapshot test'
43-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
4439

4540
linker_snapshot_tests:
4641
runs-on: ubuntu-latest-4core
@@ -65,11 +60,6 @@ jobs:
6560
run: pnpm test-linker-aot
6661
- name: Run linker tests using JIT
6762
run: pnpm test-linker-jit
68-
- uses: ./.github/actions/slack
69-
if: ${{ failure() && github.event_name == 'push' }}
70-
with:
71-
JOB_NAME: 'Linker snapshot test'
72-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
7363

7464
monitor-docs-site:
7565
runs-on: ubuntu-latest
@@ -85,9 +75,4 @@ jobs:
8575
- name: Install node modules
8676
run: pnpm install --frozen-lockfile
8777
- name: Check Docs Site
88-
run: ppnpm ci-docs-monitor-test
89-
- uses: ./.github/actions/slack
90-
if: ${{ failure() && github.event_name == 'push' }}
91-
with:
92-
JOB_NAME: 'Docs site monitoring'
93-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
78+
run: pnpm ci-docs-monitor-test

‎package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"tsc": "node ./node_modules/typescript/bin/tsc",
5151
"ci-push-deploy-docs-app": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only scripts/docs-deploy/deploy-ci-push.mts",
5252
"ci-docs-monitor-test": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only scripts/docs-deploy/monitoring/ci-test.mts",
53-
"ci-notify-slack-failure": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only scripts/circleci/notify-slack-job-failure.mts",
5453
"prepare": "husky"
5554
},
5655
"version": "20.1.0-next.0",

‎scripts/circleci/notify-slack-job-failure.mts‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

0 commit comments

Comments
 (0)