Interface Type Implementation Fix (#3358)

danielcornejo14 · davideast · web-flow · commit 59b95af3e367 · 2023-06-23T15:09:07.000Z
Co-authored-by: David East &lt;davideast@users.noreply.github.com&gt;
diff --git a/src/compat/firestore/interfaces.ts b/src/compat/firestore/interfaces.ts
@@ -13,7 +13,7 @@ export type Query<T = DocumentData> = firebase.firestore.Query<T>;
 export type SetOptions = firebase.firestore.SetOptions;
 export type DocumentData = firebase.firestore.DocumentData;
 
-export interface DocumentSnapshotExists<T> extends firebase.firestore.DocumentSnapshot {
+export interface DocumentSnapshotExists<T> extends firebase.firestore.DocumentSnapshot<T> {
   readonly exists: true;
   data(options?: SnapshotOptions): T;
 }
@@ -26,15 +26,15 @@ export interface DocumentSnapshotDoesNotExist extends firebase.firestore.Documen
 
 export type DocumentSnapshot<T> = DocumentSnapshotExists<T> | DocumentSnapshotDoesNotExist;
 
-export interface QueryDocumentSnapshot<T> extends firebase.firestore.QueryDocumentSnapshot {
+export interface QueryDocumentSnapshot<T> extends firebase.firestore.QueryDocumentSnapshot<T> {
   data(options?: SnapshotOptions): T;
 }
 
-export interface QuerySnapshot<T> extends firebase.firestore.QuerySnapshot {
+export interface QuerySnapshot<T> extends firebase.firestore.QuerySnapshot<T> {
   readonly docs: QueryDocumentSnapshot<T>[];
 }
 
-export interface DocumentChange<T> extends firebase.firestore.DocumentChange {
+export interface DocumentChange<T> extends firebase.firestore.DocumentChange<T> {
   readonly doc: QueryDocumentSnapshot<T>;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ export type Query<T = DocumentData> = firebase.firestore.Query<T>;`
`13`	`13`	`export type SetOptions = firebase.firestore.SetOptions;`
`14`	`14`	`export type DocumentData = firebase.firestore.DocumentData;`
`15`	`15`
`16`		`-export interface DocumentSnapshotExists<T> extends firebase.firestore.DocumentSnapshot {`
	`16`	`+export interface DocumentSnapshotExists<T> extends firebase.firestore.DocumentSnapshot<T> {`
`17`	`17`	`readonly exists: true;`
`18`	`18`	`data(options?: SnapshotOptions): T;`
`19`	`19`	`}`
`@@ -26,15 +26,15 @@ export interface DocumentSnapshotDoesNotExist extends firebase.firestore.Documen`
`26`	`26`
`27`	`27`	`export type DocumentSnapshot<T> = DocumentSnapshotExists<T> \| DocumentSnapshotDoesNotExist;`
`28`	`28`
`29`		`-export interface QueryDocumentSnapshot<T> extends firebase.firestore.QueryDocumentSnapshot {`
	`29`	`+export interface QueryDocumentSnapshot<T> extends firebase.firestore.QueryDocumentSnapshot<T> {`
`30`	`30`	`data(options?: SnapshotOptions): T;`
`31`	`31`	`}`
`32`	`32`
`33`		`-export interface QuerySnapshot<T> extends firebase.firestore.QuerySnapshot {`
	`33`	`+export interface QuerySnapshot<T> extends firebase.firestore.QuerySnapshot<T> {`
`34`	`34`	`readonly docs: QueryDocumentSnapshot<T>[];`
`35`	`35`	`}`
`36`	`36`
`37`		`-export interface DocumentChange<T> extends firebase.firestore.DocumentChange {`
	`37`	`+export interface DocumentChange<T> extends firebase.firestore.DocumentChange<T> {`
`38`	`38`	`readonly doc: QueryDocumentSnapshot<T>;`
`39`	`39`	`}`
`40`	`40`