This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide): improve Protractor test for bindings#9330
Closed
elgalu wants to merge 1 commit into
Closed
Conversation
Contributor
|
@juliemr is there a way to use |
Member
|
Maybe we'd prefer: nameBindings.each(function(elem) {
expect(elem.getText()).toEqual('Max Karl Ernst Ludwig Planck (April 23, 1858 – October 4, 1947)');
}); |
Contributor
This needs Protractor >= 1.3.0 to work.
Contributor
Author
|
Fixed! |
e8dc429 to
e83fab9
Compare
4dd5a20 to
998c61c
Compare
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jan 26, 2016
This needs Protractor >= 1.3.0 to work. Closes angular#9330
Narretz
pushed a commit
that referenced
this pull request
Jan 26, 2016
This needs Protractor >= 1.3.0 to work. Closes #9330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main reason is this test should be using
by.bindinglocator instead of manuallyspan[ng-bind].This needs Protractor >= 1.3.0 to work.