From e5cb64a3722f9423eacd7e941b5994fbf42a3aa0 Mon Sep 17 00:00:00 2001
From: winsontam <winsontam@gmail.com>
Date: Wed, 30 Jul 2014 11:12:55 +0800
Subject: [PATCH] fix($location) don't rewrite location when clicking on
 "javascript:" or "mailto:" link

Previously, absent a specified target attribute, when clicking on an anchor tag with an href beginning
with either "javascript:" or "mailto:", the framework would rewrite the URL, when it ought not to.

With this change, the browser is prevented from rewriting if the URL begins with a case-insensitive match
for "javascript:" or "mailto:", optionally preceeded by whitespace.

Closes #8407
Closes #8425
---
 src/ng/location.js      |  5 +++++
 test/ng/locationSpec.js | 26 ++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/src/ng/location.js b/src/ng/location.js
index 1d99e9b2ea21..a73063bd5473 100644
--- a/src/ng/location.js
+++ b/src/ng/location.js
@@ -635,6 +635,8 @@ function $LocationProvider(){
     $location = new LocationMode(appBase, '#' + hashPrefix);
     $location.$$parse($location.$$rewrite(initialUrl));
 
+    var IGNORE_URI_REGEXP = /^\s*(javascript|mailto):/i;
+
     $rootElement.on('click', function(event) {
       // TODO(vojta): rewrite link when opening in new tab/window (in legacy browser)
       // currently we open nice url link and redirect then
@@ -657,6 +659,9 @@ function $LocationProvider(){
         absHref = urlResolve(absHref.animVal).href;
       }
 
+      // Ignore when url is started with javascript: or mailto:
+      if (IGNORE_URI_REGEXP.test(absHref)) return;
+
       // Make relative links work in HTML5 mode for legacy browsers (or at least IE8 & 9)
       // The href should be a regular url e.g. /link/somewhere or link/somewhere or ../somewhere or
       // somewhere#anchor or http://example.com/somewhere
diff --git a/test/ng/locationSpec.js b/test/ng/locationSpec.js
index e586ad744b6a..2dfca7912353 100644
--- a/test/ng/locationSpec.js
+++ b/test/ng/locationSpec.js
@@ -1028,6 +1028,32 @@ describe('$location', function() {
     });
 
 
+    it('should not rewrite links with `javascript:` URI', function() {
+      configureService(' jAvAsCrIpT:throw new Error("Boom!")', true, true, true);
+      inject(
+        initBrowser(),
+        initLocation(),
+        function($browser) {
+          browserTrigger(link, 'click');
+          expectNoRewrite($browser);
+        }
+      );
+    });
+
+
+    it('should not rewrite links with `mailto:` URI', function() {
+      configureService(' mAiLtO:foo@bar.com', true, true, true);
+      inject(
+        initBrowser(),
+        initLocation(),
+        function($browser) {
+          browserTrigger(link, 'click');
+          expectNoRewrite($browser);
+        }
+      );
+    });
+
+
     it('should rewrite full url links to same domain and base path', function() {
       configureService('http://host.com/base/new', true);
       inject(