Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(error): redefining module causes $injector:unpr#8421

Closed
ksheedlo wants to merge 1 commit into
angular:masterfrom
ksheedlo:docs-redefmodule-unpr
Closed

docs(error): redefining module causes $injector:unpr#8421
ksheedlo wants to merge 1 commit into
angular:masterfrom
ksheedlo:docs-redefmodule-unpr

Conversation

@ksheedlo
Copy link
Copy Markdown
Contributor

@ksheedlo ksheedlo commented Jul 30, 2014

No description provided.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 30, 2014

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@ksheedlo ksheedlo added cla: no and removed cla: yes labels Jul 30, 2014
@ksheedlo
Copy link
Copy Markdown
Contributor Author

ksheedlo commented Jul 30, 2014

CLA signed with my rackspace email. Please check this again.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 30, 2014

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@ksheedlo ksheedlo removed the cla: no label Jul 30, 2014
@RichardLitt RichardLitt added this to the Backlog milestone Jul 30, 2014
@petebacondarwin petebacondarwin modified the milestones: Backlog, 1.3.0-beta.18 Jul 31, 2014
@petebacondarwin petebacondarwin self-assigned this Jul 31, 2014
@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Jul 31, 2014

LGTM

petebacondarwin pushed a commit that referenced this pull request Jul 31, 2014
@petebacondarwin
docs(error/$injector/unpr): inadvertently redefining a module can cau…
98ff901 
…se error

Closes #8421
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@petebacondarwin petebacondarwin

Labels

cla: yes needs: merging type: docs

Projects

None yet

Milestone

1.3.0-beta.18

Development

Successfully merging this pull request may close these issues.

4 participants

@ksheedlo @mary-poppins @petebacondarwin @RichardLitt