This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Trim arguments#829
Closed
recht wants to merge 1 commit into
Closed
Conversation
… declaration in Chrome
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Mar 29, 2012
Previously if there was a white-space in fn: fn( ) {} we failed to infer no args.
This was originally reported by recht, but I decided to use a different fix.
Closes angular#829
Contributor
|
Thanks for the report! I took a slightly different approach to fix this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that if you have a function like this: function ( ) { }, Chrome will return the space in the empty parameter list while Firefox will not. This means that the injection lookup will get a string like this: " ", which is not handled in inferInjectionArgs.