Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix whitespace#8277

Closed
treyhunner wants to merge 3 commits into
angular:masterfrom
treyhunner:fix-whitespace
Closed

Fix whitespace#8277
treyhunner wants to merge 3 commits into
angular:masterfrom
treyhunner:fix-whitespace

Conversation

@treyhunner
Copy link
Copy Markdown
Contributor

@treyhunner treyhunner commented Jul 21, 2014

Request Type: chore

How to reproduce:

Component(s):

Impact:

Complexity: small

This issue is related to:

Detailed Description:

Other Comments:

This involves multiple whitespace-only changes:

  • Convert some tab indentation to spaces
  • Trim all trailing spaces
  • Add final newlines that are missing from some files

Doing a git diff -w master will confirm that this is a whitespace-only change. Adding ?w=1 to the files changed URL also demonstrates this.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 21, 2014

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8277)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@treyhunner treyhunner mentioned this pull request Jul 21, 2014
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 21, 2014

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@treyhunner
Copy link
Copy Markdown
Contributor Author

treyhunner commented Jul 21, 2014

I have now signed the CLA.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 21, 2014

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@IgorMinar IgorMinar self-assigned this Jul 21, 2014
IgorMinar pushed a commit that referenced this pull request Jul 21, 2014
@treyhunner @IgorMinar
style: fix whitespace issues
1c15cdc 
Closes #8277

Conflicts:
	docs/content/guide/migration.ngdoc
@IgorMinar IgorMinar closed this in a54d460 Jul 21, 2014
@treyhunner treyhunner deleted the fix-whitespace branch July 21, 2014 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@IgorMinar IgorMinar

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@treyhunner @mary-poppins @IgorMinar