Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngValue) Replace input[select] with option for clarity#8203

Closed
timraymond wants to merge 1 commit into
angular:masterfrom
timraymond:docs-correct-ng-value-option
Closed

docs(ngValue) Replace input[select] with option for clarity#8203
timraymond wants to merge 1 commit into
angular:masterfrom
timraymond:docs-correct-ng-value-option

Conversation

@timraymond
Copy link
Copy Markdown
Contributor

@timraymond timraymond commented Jul 15, 2014

Request Type: docs

How to reproduce:

Component(s): forms

Impact:

Complexity: small

This issue is related to:

Detailed Description:

It is impossible to create an input[select], so it appears the intention
here was actually option.

While ngOptions would probably be easier to use in most cases, someone may have a use case for using ngValue with option which is why I decided to change it in lieu of deleting it, as had been mentioned in the issue.

Other Comments:

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 15, 2014

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8203)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@timraymond
docs(ngValue):Replace input[select] with option for clarity
5ffef11 
It is impossible to create an `input[select]`, so it appears the intention
here was actually `option`.

Fixes angular#7994
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 15, 2014

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz Narretz added this to the 1.3.0 milestone Jul 16, 2014
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Jul 17, 2014

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford btford removed the gh: PR label Aug 20, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:09
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37
@Narretz Narretz closed this in ce20dd0 Oct 29, 2014
@mend-for-github-com mend-for-github-com Bot mentioned this pull request Feb 8, 2024
Open
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes type: docs

Projects

None yet

Milestone

1.3.x - superluminal-nudge

Development

Successfully merging this pull request may close these issues.

4 participants

@timraymond @mary-poppins @btford @Narretz